Fix deprecated keys in setup.cfg #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jezdez
approved these changes
May 19, 2022
ocefpaf
commented
May 19, 2022
| @@ -1,4 +1,7 @@ | |||
| from setuptools import setup | |||
|
|
|||
|
|
|||
| setup(use_scm_version=True) | |||
| setup( | |||
| name="conda_lock", | |||
There was a problem hiding this comment.
Note that this is not really needed for the package but for GitHub. It cannot compute the projects that depends on this without the name in setup.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge this yet. I'm trying to make it possible to install from the GitHub main branch too but I need to make a few extra adjustments.Actually this is not needed, one can just install from "git" instead of a zipped git URL, from the error message:
This is ready for review now.