Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PDM support #173

Merged
merged 4 commits into from
Mar 15, 2022
Merged

Add PDM support #173

merged 4 commits into from
Mar 15, 2022

Conversation

leroyvn
Copy link
Contributor

@leroyvn leroyvn commented Mar 13, 2022

This PR closes #133 and adds support for PDM's tool.pdm.dev-dependencies table.

PDM uses PEP 621 dependency specifications and adds an extra tool.pdm.dev-dependencies table with dependencies used for development but not intended to appear as package metadata. For simplicity, all those dependencies are assigned the dev category. The parsing code comes with tests.

Docs also need a little update, I'll go through them ASAP.

To do:

  • Update documentation
  • Fix failing checks

@netlify
Copy link

netlify bot commented Mar 13, 2022

✔️ Deploy Preview for conda-lock ready!

🔨 Explore the source changes: 48d21ad

🔍 Inspect the deploy log: https://app.netlify.com/sites/conda-lock/deploys/62306a9bd211ec0008c72700

😎 Browse the preview: https://deploy-preview-173--conda-lock.netlify.app/src_pyproject

@mariusvniekerk
Copy link
Collaborator

We have some docs for the the format here if you want to mention PDM in there

@leroyvn
Copy link
Contributor Author

leroyvn commented Mar 15, 2022

Thanks @mariusvniekerk; I edited the docs and added a mention to PDM. I also put a disclaimer on the implemented behavior, since I haven't used conda-lock with PDM in production yet: stuffing everything found in tool.pdm.dev-dependencies in the dev category may not be best.

@mariusvniekerk mariusvniekerk merged commit 388db9f into conda:main Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Current status of PEP 621 metadata support, usage with PDM
2 participants