Fix conda lock install on windows #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unify the way we make temporary files and pass them to conda. This should fix PermissionError issues on windows
|
✔️ Deploy Preview for conda-lock ready! 🔨 Explore the source changes: c26bf0d 🔍 Inspect the deploy log: https://app.netlify.com/sites/conda-lock/deploys/6228ec38e324920008efb772 😎 Browse the preview: https://deploy-preview-167--conda-lock.netlify.app |
| def temporary_file_with_contents(content: str) -> Iterator[pathlib.Path]: | ||
| """Generate a temporary file with the given content. This file can be used by subprocesses | ||
|
|
||
| On Windows, NamedTemporaryFiles can't be opened a second time, so we have to close it first (and delete it manually later) |
There was a problem hiding this comment.
you can create a tempfile.TemporaryDirectory and put the file there, after it leaves the context manager the folder will be deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165
Unify the way we make temporary files and pass them to conda. This should fix PermissionError issues on windows