-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make gitpython dependency optional? #296
Comments
Strawman PR up in #297. |
make gitpython dependency optional
Thanks! |
CVE-2024-22190 is up. can we reconsider the hard dep, and make it an extra? |
Ugh, yes, given the history I think making it an extra makes a lot of sense. |
As mentioned before: as of now,
Pretty much everything else could be an |
@bollwyvl, Seems like a bit of a project, but I'd totally support that. I think it'd help a lot with code quality too. I don't really have any time to push it forward right now though. @mariusvniekerk, what do you think? |
#204's adding the hard dep on
gitpython
lights up vulnerability scanners forCVE-2022-24439
. Here's the upstream issue:<gitpython::clone> 'ext::sh -c touch% /tmp/pwned'
for remote code execution gitpython-developers/GitPython#1515As there's no particular timeline for a fix, perhaps the
gitpython
dependency could be made optional, as withpip
for the non-vendored bits ofpoetry
?The text was updated successfully, but these errors were encountered: