-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document split package usage in conda-build #388
Conversation
outputs: | ||
- name: subpackage-name | ||
script: some-script.extension | ||
script_interpreter: program plus arguments to run script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msarahan it may be my RPM bias talking but I am not sure if using an external script to organize the sub-packages is a good idea. Anyway, the option to list the files also exists, so I guess it is up to the user decide what s/he wants.
This improvement is awesome. IMO it places |
Coming from an ArchLinux/msys2 background I'm strongly in favour of a procedural approach.
|
I'm personally in favor of the procedural approach, too. I included the files option for those that have an RPM or RPM-like slant. Whatever people want to do is fine, IMHO, and we shouldn't force either way. FWIW, I think globs make the files approach much less fragile. |
That's me 😄 |
c2f6bc4
to
8ce5b5e
Compare
cycled to trigger rebuild |
8ce5b5e
to
6fe1454
Compare
@cio-docs please review. This feature is live in conda-build 2.1.0. |
Reviewing now. |
Just to make certain, it's correct that the scripts to create or move files into the build prefix can be py/bat/sh/ps1 and the test scripts can be py/bat/sh/pl , right? |
writing tweaks
Thanks for the review @electronwill - the scripts are correct. That's somewhat frustratingly inconsistent, and I'd like to eventually unify it. Unfortunately, this is all I have time for right now. |
No problem. Almost no large system is ever perfectly consistent everywhere. As long as these small variations are documented accurately, we're doing great. I'm done reviewing. I suggested a few small changes to the writing. Everything else looks great! |
Thanks for the review. Merging. |
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
This is a new feature, to be added in the coming conda-build 2.1.0 release.