Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document split package usage in conda-build #388

Merged
merged 3 commits into from
Feb 15, 2017

Conversation

msarahan
Copy link
Contributor

This is a new feature, to be added in the coming conda-build 2.1.0 release.

outputs:
- name: subpackage-name
script: some-script.extension
script_interpreter: program plus arguments to run script
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msarahan it may be my RPM bias talking but I am not sure if using an external script to organize the sub-packages is a good idea. Anyway, the option to list the files also exists, so I guess it is up to the user decide what s/he wants.

@ocefpaf
Copy link

ocefpaf commented Dec 22, 2016

This improvement is awesome. IMO it places conda in a higher level of package managers like yum and apt-get. Thanks for implementing this. I will test it soon and report back.

@mingwandroid
Copy link
Contributor

Coming from an ArchLinux/msys2 background I'm strongly in favour of a procedural approach.

make install subtarget is the most common way to do it. Listing files is brittle and needs constant gardening IMHO.

@msarahan
Copy link
Contributor Author

I'm personally in favor of the procedural approach, too. I included the files option for those that have an RPM or RPM-like slant. Whatever people want to do is fine, IMHO, and we shouldn't force either way.

FWIW, I think globs make the files approach much less fragile.

@ocefpaf
Copy link

ocefpaf commented Dec 22, 2016

I included the files option for those that have an RPM or RPM-like slant

That's me 😄

@msarahan
Copy link
Contributor Author

cycled to trigger rebuild

@msarahan
Copy link
Contributor Author

@cio-docs please review. This feature is live in conda-build 2.1.0.

@electronwill
Copy link
Contributor

Reviewing now.

@electronwill
Copy link
Contributor

Just to make certain, it's correct that the scripts to create or move files into the build prefix can be py/bat/sh/ps1 and the test scripts can be py/bat/sh/pl , right?

writing tweaks
@msarahan
Copy link
Contributor Author

Thanks for the review @electronwill - the scripts are correct. That's somewhat frustratingly inconsistent, and I'd like to eventually unify it. Unfortunately, this is all I have time for right now.

@electronwill
Copy link
Contributor

No problem. Almost no large system is ever perfectly consistent everywhere. As long as these small variations are documented accurately, we're doing great.

I'm done reviewing. I suggested a few small changes to the writing. Everything else looks great!

@msarahan
Copy link
Contributor Author

Thanks for the review. Merging.

@msarahan msarahan merged commit 9a81bad into conda:master Feb 15, 2017
@msarahan msarahan deleted the conda-build-split-packages branch February 15, 2017 19:35
@github-actions
Copy link

Hi there, thank you for your contribution!

This pull request has been automatically locked because it has not had recent activity after being closed.

Please open a new issue or pull request if needed.

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants