Add benchmark test for render_recipe
#5490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
CodSpeed Performance ReportMerging #5490 will not alter performanceComparing Summary
Benchmarks breakdown
|
isuruf
approved these changes
Sep 17, 2024
kenodegard
added a commit
to minrk/conda-build
that referenced
this pull request
Sep 18, 2024
beeankha
added a commit
that referenced
this pull request
Sep 18, 2024
* discard unused variants before copying metadata when variant matrix is large and mostly unused (as in conda-forge), the length of input_variants may be several thousand when only a few are actually used. This causes `get_loop_vars` and `metadata.copy()` to become very expensive. * try reducing with all used vars instead of loop vars should reduce less * perf: copy distributed variants list after subsetting vastly reduces the number of copies computed for large variant matrices * perf: pass used_vars subset to get_loop_vars rather than computing all loop vars and then intersecting, only consider relevant keys when computing loop vars reduces get_used_loop_vars from O(n_vars * n_variants) to O(n_used_vars * n_variants) * remove redundant deepcopy of config.variant config.copy already copies this, no need to do it twice in metadata.copy * add config.copy_variants method to avoid calling pickle in too many places * Update news/5392-variant-copy * Add benchmark test for `render_recipe` (#5490) --------- Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com> Co-authored-by: Bianca Henderson <beeankha@gmail.com> Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
render_recipetest for #5392. This is added separately so we can see the benchmark speedups in the other PR via CodSpeed.Checklist - did you ...
Add a file to thenewsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?