Remove xdoctest & ignore libgcc for overlinking/overdepending checks
#5471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
This was referenced Aug 30, 2024
CodSpeed Performance ReportMerging #5471 will not alter performanceComparing Summary
|
beeankha
previously approved these changes
Aug 30, 2024
kenodegard
force-pushed
the
remove-xdoctest
branch
from
c55aa34
to
fa56df3
Compare
kenodegard
changed the title
xdoctestxdoctest & ignore compiler's run_exports
This reverts commit fa56df3.
kenodegard
changed the title
xdoctest & ignore compiler's run_exportsxdoctest & ignore libgcc for overlinking/overdepending checks
beeankha
approved these changes
Sep 4, 2024
isuruf
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found that while we were passing
--xdoctest-moduleswe haven't actually been running any docstring example codes anyhow sincepytestonly crawls thetestsdirectory by default.Correcting this (and/or switching to use
doctestsinstead) is out of scope and relegated to a future effort.Also ignoring over depending checks for
libgccon linux as was previously done forlibgcc-ngsince conda-forge recently renamedlibgcc-ngtolibgcc.Closes #5470
Closes #5469
Closes #5468
Closes #5475
Closes #5476
Checklist - did you ...
Add a file to thenewsdirectory (using the template) for the next release's release notes?Add / update necessary tests?Add / update outdated documentation?