-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs regarding base env use #5004
Conversation
We require contributors to sign our Contributor License Agreement and we don't have one on file for @DaveKaretnyk. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#824), and ping the bot to refresh the PR. |
@conda-bot check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got some general punctuation/wording suggestions. Let me know if you have any questions and thanks for your contribution!
@kathatherine: thanks, updated content as per house style. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few edit suggestions, otherwise LGTM!
Co-authored-by: Bianca Henderson <beeankha@gmail.com>
Thanks all for the review comments, making the final changes, and merging. I have a question regarding your procedures, especially for doc changes like this. Should the submitter (me) make / discuss the review suggestions or should it be left to Anaconda employees to take care of? E.g. a bunch of them are house style changes.... |
@DaveKaretnyk either works, simple grammatical and formatting changes are often just committed by maintainers (done with good intentions in an effort to decrease the amount of back and forth necessary), more substantial changes will likely to be discussed further |
Update conda-build docs to recommend use with base-env only
Documentation solution to problem discussed here: #4995
Checklist - did you ...
news
directory (using the template) for the next release's release notes?