Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs regarding base env use #5004

Merged
merged 6 commits into from
Sep 16, 2023
Merged

Update docs regarding base env use #5004

merged 6 commits into from
Sep 16, 2023

Conversation

DaveKaretnyk
Copy link
Contributor

@DaveKaretnyk DaveKaretnyk commented Sep 15, 2023

Update conda-build docs to recommend use with base-env only

Documentation solution to problem discussed here: #4995

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @DaveKaretnyk.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#824), and ping the bot to refresh the PR.

@kenodegard
Copy link
Contributor

@conda-bot check

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Sep 15, 2023
@DaveKaretnyk DaveKaretnyk marked this pull request as ready for review September 15, 2023 19:06
Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got some general punctuation/wording suggestions. Let me know if you have any questions and thanks for your contribution!

docs/source/install-conda-build.rst Outdated Show resolved Hide resolved
docs/source/install-conda-build.rst Outdated Show resolved Hide resolved
docs/source/install-conda-build.rst Outdated Show resolved Hide resolved
docs/source/install-conda-build.rst Outdated Show resolved Hide resolved
docs/source/install-conda-build.rst Outdated Show resolved Hide resolved
docs/source/install-conda-build.rst Outdated Show resolved Hide resolved
@DaveKaretnyk
Copy link
Contributor Author

@kathatherine: thanks, updated content as per house style.

kathatherine
kathatherine previously approved these changes Sep 15, 2023
Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

beeankha
beeankha previously approved these changes Sep 16, 2023
Copy link
Member

@beeankha beeankha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few edit suggestions, otherwise LGTM!

Co-authored-by: Bianca Henderson <beeankha@gmail.com>
@jezdez jezdez dismissed stale reviews from beeankha and kathatherine via d29a69e September 16, 2023 10:07
docs/source/install-conda-build.rst Outdated Show resolved Hide resolved
docs/source/install-conda-build.rst Outdated Show resolved Hide resolved
news/4995-run-conda-build-in-base-env Outdated Show resolved Hide resolved
@jezdez jezdez enabled auto-merge (squash) September 16, 2023 10:10
@jezdez jezdez merged commit 735e506 into conda:main Sep 16, 2023
12 checks passed
@DaveKaretnyk
Copy link
Contributor Author

Thanks all for the review comments, making the final changes, and merging.

I have a question regarding your procedures, especially for doc changes like this. Should the submitter (me) make / discuss the review suggestions or should it be left to Anaconda employees to take care of? E.g. a bunch of them are house style changes....

@kenodegard
Copy link
Contributor

@DaveKaretnyk either works, simple grammatical and formatting changes are often just committed by maintainers (done with good intentions in an effort to decrease the amount of back and forth necessary), more substantial changes will likely to be discussed further

@kenodegard kenodegard linked an issue Sep 18, 2023 that may be closed by this pull request
@kenodegard kenodegard mentioned this pull request Sep 26, 2023
36 tasks
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Sep 16, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Must conda-build be installed in the base envt?
6 participants