Use actions-ecosystem/action-add/remove-labels #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
|
That's reasonable, https://github.com/actions-ecosystem is relatively well-known and trust-worthy. But as the GitHub docs mention, we should "harden" our use of GHA by referring to commit, not tags. |
jezdez
previously requested changes
Mar 1, 2023
|
related to that: Would be interesting to figure out how to update the pinned sha1s to newer tagged versions via dependabot/renovate ... dependabot seems to only supports .github/workflow/*.yml files... no composite action.yml support even though the syntax and versioning is the same.. not sure about renovate |
|
@dbast per this SO post, dependabot understands composite actions: https://stackoverflow.com/a/74997644/5239932 |
dbast
previously approved these changes
Mar 3, 2023
dbast
approved these changes
Mar 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of using a custom implementation of adding/removing labels, should we use the third-party action (https://github.com/actions-ecosystem/action-add-labels, https://github.com/actions-ecosystem/action-remove-labels)?
Checklist - did you ...
Add a file to thenewsdirectory (using the template) for the next release's release notes?Add / update necessary tests?Add / update outdated documentation?