Refactor tool downloading and output, add Windows MiniForge example

[bollwyvl]

• fixes installer-url option triggers an error on windows #97

Code Changes:

• rework the download to unify the behavior of the miniconda downloader (which was obvioiusly working) and the custom one
• rework outputs
• in example 5, update miniforge, add windows examples, use "nasty" urls with &?#

[bollwyvl]

Very close now...

[goanpeca]

?foo=bar&baz Is this related to cache?

[goanpeca]

Oh nevermind, you used it to test the url parsing.

Right @bollwyvl ?

[bollwyvl]

Yep, just want to make sure we've got an out for the inevitable s3 trash or wherever people are putting these things. Actually, going to add some docs about that...

[goanpeca]

Hmm good point should have added this to the other PRs :-p

@jaimergp would you like to update this on the changelog with the PRs you started?

[jaimergp]

Oops, yep, will do!

[goanpeca]

No worries I forgot too 🤦🏽

[goanpeca]

Awesome work @bollwyvl

Thanks a lot!

[bollwyvl]

Thanks for the review!

Looking over the logs, tc.find never seems to get a cache hit... will investigate.

[bollwyvl]

Ah, I was banging my head against paths and escaping: turns out tar is just broken on windows: actions/toolkit#632

I still think we want to use the exec(cmd[0], cmd.slice(1)) everywhere, just seems like fewer surprises...

[goanpeca]

I still think we want to use the exec(cmd[0], cmd.slice(1)) everywhere, just seems like fewer surprises...

Agreed. Good to merge then?

[bollwyvl]

Sorry my attention is a bit async right now... it looks like file:/// works like a boss (probably a PITA on windows, but so it goes), but this is pretty clutch for being able to test an installer built somewhere else during a workflow without turning on a web server or something.

No further changes planned!

[goanpeca]

No further changes planned!

You pinky promise?

[bollwyvl]

we swears. I'm working conda-forge chores now 😫