-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve dependencies and rebuild, squash warnings #79
Conversation
The upgrade reveals some new warnings: https://github.com/conda-incubator/setup-miniconda/actions/runs/291485813
as well as of course the conda upgrade... will take a look into squashing them... |
looks like that's just some juiced-up warnings... the only thing i've seen is to redirect the output, e.g. |
ah, i see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @bollwyvl
Are we good to merge after tests pass? |
I'd like to get all the errors we know about today squashed, since that's what people see... so some approach from #58 (comment) would be good... |
Ok, I have the ones from #79 (comment) squared away. We just need to pick (some) approaches for the conda update notify, happy to do them here! |
Ping me or merge when ready @bollwyvl the overall approach looks good, so thanks again :-) |
@goanpeca Ok, the bootstrap |
the only warning this action doesn't emit is the |
Pushed for #79 (comment) (Other Shells should have no warnings) |
Yep, that did it: we're down to just first-party warnings, not planning to do anything else here... |
Hooray!
|
So can this already be tested out, or do we need a release? |
Trying out https://github.com/krassowski/jupyterlab-lsp/pull/348/checks?check_run_id=1216272360 |
…set-env and add-path
This resolves the dependencies updates suggested by #77 and #69, but also runs the build so might be simpler than taking those.
This should also fix #78 (once released).