Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add architecture option to installation candidates #52

Merged
merged 4 commits into from
Aug 12, 2020

Conversation

bryanwweber
Copy link
Contributor

The user can select an architecture supported by their Actions runner as
an option in the with block.

Closes #10

The user can select an architecture supported by their Actions runner as
an option in the with block.

Closes conda-incubator#10
@bryanwweber
Copy link
Contributor Author

bryanwweber commented Jun 30, 2020

This appears not to have done anything so far, see: https://github.com/Cantera/conda-recipes/pull/22/checks?check_run_id=823649924#step:3:15 which is still using the pre-installed Miniconda

I'm not sure if I need to add the built index.js here to be able to use this branch in my tests, linked above. I tried adding the output of npm build . to git (in dee11bd) but it didn't change the result of my check here: https://github.com/Cantera/conda-recipes/pull/22/checks?check_run_id=823678396#step:3:12 (which I started after pushing to this branch)

@goanpeca
Copy link
Member

Hi @bryanwweber thanks for taking look. Now, we need to force a miniconda install from scratch for this to work, since it is not possible to "change" the architecture and user the bundled one. So if miniconda-version is not provided, we need to use "latest" to force a install.

@bryanwweber
Copy link
Contributor Author

bryanwweber commented Jun 30, 2020

Thanks for the feedback! I had interpreted this line:
https://github.com/goanpeca/setup-miniconda/blob/03cf5633af2fd0e98baa281a7f2803c2417d7c83/src/setup.ts#L654

as: "if minicondaVersion is set OR architecture isn't equal to x64", in which case, when I set architecture to x86, it should go through the install steps. Did I miss something?

Looking at it now, I see that minicondaVersion might have to be set in addition to architecture. Or rather, if architecture is set, then minicondaVersion must also be set. Should I add a conditional that checks for that?

Make sure that architectures other than x86_64 can be downloaded.
@joergbrech
Copy link

@bryanwweber, @goanpeca, I really like the setup-miniconda action and I could use the architecture option for several projects! Great work! What ist the status on this PR?

BTW, I played around with this the bryanwweber:fix-10 branch, and it works great, except for one issue with x86 Miniconda on ubuntu-latest:

https://github.com/DLR-SC/tigl-conda/runs/965599369?check_suite_focus=true#step:3:66

Do you have an idea what this is about? Is this a permission issue?

@bryanwweber
Copy link
Contributor Author

@joergbrech It seems as though Anaconda have dropped support for x86 Linux, the installer is from January of last year (2019)
https://repo.anaconda.com/miniconda/ I would not suggest relying on that working. You may want to try and set up a local x86 Linux machine to debug, and if you find something, I'd be happy to include a fix here.

@goanpeca
Copy link
Member

goanpeca commented Aug 10, 2020

Hi @bryanwweber, sorry I have swamped with work, and I still have to review this!


Thanks @joergbrech, indeed I do not think the Linux issue is solvable (we should probably disallow it @bryanwweber)

@joergbrech
Copy link

It seems as though Anaconda have dropped support for x86 Linux, the installer is from January of last year (2019)

Ah, I did not know that. Thanks for the info. I am looking forward to this being merged! Thanks again for the great work!

@bryanwweber
Copy link
Contributor Author

Thanks @goanpeca I'll try to add another check for that condition. No problem about the delay, we ended up just dropping Win32 support for our package rather than trying to build the conda package, so I ended up not needing this feature 😄

Anaconda appear to have dropped support for 32-bit Linux distributions
sometime in 2019.
@bryanwweber
Copy link
Contributor Author

@goanpeca I've pushed a change that errors out when 32-bit Linux is used

@goanpeca
Copy link
Member

Awesome! I will merge an iterate! Thanks!

@goanpeca goanpeca merged commit d6bafe2 into conda-incubator:master Aug 12, 2020
@bryanwweber bryanwweber deleted the fix-10 branch August 12, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow 32 bit option
3 participants