Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect and support Linux ARM runners for both Miniconda and Miniforge #387

Merged
merged 13 commits into from
Jan 20, 2025
Merged

Detect and support Linux ARM runners for both Miniconda and Miniforge #387

merged 13 commits into from
Jan 20, 2025

Conversation

jaimergp
Copy link
Member

Closes #385

@jaimergp jaimergp requested a review from a team as a code owner January 20, 2025 11:03
@jaimergp
Copy link
Member Author

jaimergp commented Jan 20, 2025 •
edited
Loading

@conda-incubator/setup-miniconda, ready for review, thanks! (Mamba errors are unrelated).

travishathaway
travishathaway reviewed Jan 20, 2025
View reviewed changes
travishathaway
travishathaway reviewed Jan 20, 2025
View reviewed changes
travishathaway
travishathaway reviewed Jan 20, 2025
View reviewed changes
travishathaway
travishathaway suggested changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@travishathaway travishathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions. I think you got some of the example numbers mixed up.

@jaimergp @travishathaway
13 -> 15
60efbd1 
Co-authored-by: Travis Hathaway <travis.j.hathaway@gmail.com>
@jaimergp
Copy link
Member Author

Oops, thank you @travishathaway!

jezdez
jezdez approved these changes Jan 20, 2025
View reviewed changes
jaimergp and others added 3 commits January 20, 2025 18:29
@jaimergp @jezdez
Update README.md
19e2dab 
Co-authored-by: Jannis Leidel <jannis@leidel.info>
@jaimergp
update ids
ba47885
@jaimergp
Merge branch 'linux-aarch64' of github.com:conda-incubator/setup-mini…
0705e65 
…conda into linux-aarch64
@jaimergp jaimergp changed the title Detect and support Linux ARM runners Detect and support Linux ARM runners for both Miniconda and Miniforge Jan 20, 2025
@jaimergp jaimergp merged commit 7611e53 into main Jan 20, 2025
86 checks passed
@jaimergp jaimergp deleted the linux-aarch64 branch January 20, 2025 17:46
@wojiushixiaobai wojiushixiaobai mentioned this pull request Jan 21, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travishathaway travishathaway travishathaway requested changes

@jezdez jezdez jezdez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to support Linux arm64 hosted runners
3 participants
@jaimergp @jezdez @travishathaway