-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make conda’s package directories configurable #328
Conversation
This adds the ability to use D: on Windows runners, to increase speed of decompression.
Thanks for this work @jezdez ! Left a couple of minor comments 🚀 |
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com> Co-authored-by: Ken Odegard <kodegard@anaconda.com>
@conda-incubator/setup-miniconda any takers for another review? |
Code looks good! Are there any issues with cross-drive hardlinking? I think Windows doesn't like creating those junctions over different units (or if the underlying drive is different), so maybe this is ends up becoming a performance hit if the env is not in the same drive. So, I wonder if:
|
@jaimergp I don't have answers for this at the moment |
I don't know why npm is adding all that cruft to dist/delete/index.js :( |
Afaik the reason is: every new function used from a dependency is copied into the index.js ( |
Now that conda-incubator/setup-miniconda#328 is merged.
- use cross-platform compatible cache on GHA Windows runners - Use separate volume for high restore and save speed Xrefs conda-incubator/setup-miniconda#328 and conda/conda-build#5082
- Use cross-platform compatible cache on GHA Windows runners - Use separate volume for high restore and save speed Xrefs conda-incubator/setup-miniconda#328 and conda/conda-build#5082
This adds the ability to use
D:
instead ofC:
on GitHub hosted Windows runners, to increase the speed of decompression.See conda/conda-build#5082 (comment) for more information.