Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #300

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Fix CI #300

merged 2 commits into from
Nov 16, 2023

Conversation

dbast
Copy link
Member

@dbast dbast commented Nov 15, 2023

Includes:

  • Run npm run format + npm run build (first commit)
  • Fix Example 6 + 10 (second commit)

Fixes the lint workflow + failing example workflows.

@dbast dbast changed the title Run "npm run format" + "npm run build" Fix CI on develop branch Nov 15, 2023
@dbast dbast changed the title Fix CI on develop branch Fix CI Nov 15, 2023
@goanpeca
Copy link
Member

goanpeca commented Nov 15, 2023

@dbast thanks for the PR. Could I request 2 things:

  • Do you have the latest develop?
  • Could you please open a PR from a branch in a fork, or from a separate branch within the same repo?

Thanks :)

@dbast
Copy link
Member Author

dbast commented Nov 16, 2023

@goanpeca Should be exactly what I did.. the PR is from a branch in my fork and one single commit head of current develop branch.... trying to get all of the workflow green :) ... will require more commit.

@goanpeca
Copy link
Member

goanpeca commented Nov 16, 2023

😅 @dbast what I meant to say is to have a branch name on your fork that does not have the same name as the target branch 😄

Since all the development work goes to the develop branch, is just better to keep things tidy

So that instead of this

conda-incubator:develop <- dbast:develop

It is more like this (for next time)

conda-incubator:develop <- dbast:fix-ci

@dbast dbast marked this pull request as ready for review November 16, 2023 18:16
@dbast
Copy link
Member Author

dbast commented Nov 16, 2023

yay... all workflows green on develop branch!

@conda-incubator/setup-miniconda ready for review/merge :)

@goanpeca goanpeca merged commit 4830701 into conda-incubator:develop Nov 16, 2023
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants