[4 of #107] replace destructuring with input member access #124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes the work in #123 by removing the huge object destructuring in
setup
, and usesinputs.<action input>
throughout. It also removes the configuration checks which will have already been handled at parsing time byinputs
. This allows for dropping a few imports 🎉.Follow-ons:
This further reveals
condaConfig
, and the rest of the "mutable state" during the run is down to:though additional mutable variables get added further down. However, the only part of the
condaConfig
that gets changed is channels, and actually gets co-mingled with what is read from an environment. Looks like #120 bears on this as well.Proposal
From 107
There might be a better name, but it's a little easier to demonstrate when the surrounding code is brought over: it replaces most function specs with
(inputs, dynamicOptions)
. Things get a little messy withmamba
, etc. but that lies further ahead...