Switch from distutils LooseVersion to Version #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
|
Warning: I haven't run the tests locally, and I'm not sure if there are differences between |
jfrost-mo
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Looks fine to me. Version has slightly different semantics to LooseVersion, but really only around handling of very weird version numbers. This shouldn't be an issue, as conda and mamba both use sane versions.
I've lightly tested, and it appears to work with the changes, including in python 3.12.
2 tasks
|
@mariusvniekerk sorry for the ping, but would it be possible to get this reviewed and merged? Its currently causing ensureconda to fail on Python 3.12. |
|
Ping @mariusvniekerk, any way to get a quick merge/release for this? |
|
Sorry for ping again, it's stuck too long. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
Checklist
newsentry