Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run_constrained #84

Closed
wants to merge 5 commits into from
Closed

Add run_constrained #84

wants to merge 5 commits into from

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Feb 28, 2023

From https://github.com/pydata/xarray/blob/main/ci/requirements/min-all-deps.yml with only netcdf4, h5netcdf, zarr backends specified.

Closes pydata/xarray#7467

Checklist

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@dcherian
Copy link
Contributor Author

@conda-forge-admin, please rerender

recipe/meta.yaml Outdated Show resolved Hide resolved
@dcherian dcherian marked this pull request as draft February 28, 2023 23:09
@jhamman
Copy link
Member

jhamman commented Mar 6, 2023

To check my understanding of what this does, this will warn (or error?) when a user tries to install xarray into a environment where one of the listed optional dependencies is out of range from what is listed in run_constrained?

@ocefpaf
Copy link
Member

ocefpaf commented Mar 6, 2023

@jhamman that will error out with a package conflict message. It is, in a way, the best way to control optional dependencies version.

@dcherian
Copy link
Contributor Author

dcherian commented Mar 6, 2023

And when creating a new env, it'll ensure these minimum versions even if the env file doesn't list them?

@ocefpaf
Copy link
Member

ocefpaf commented Mar 7, 2023

And when creating a new env, it'll ensure these minimum versions even if the env file doesn't list them?

Nope. The user must list the optional dependencies. The user can drop the min versions pin though, the solver will do te right thing and respect the run constraints in xarray.

@dcherian
Copy link
Contributor Author

dcherian commented Mar 7, 2023

Right that's what I meant. Sorry for nbeing unclear.

The user lists all the packages they want; and the solver will respect xarray's run constraints. Sounds like a feature!

We should have a policy on what to list here though: pydata/xarray#7573

Should Xarray limit iris for example? It seems like almost no one is converting xarray datasets to iris or vice versa.

@ocefpaf
Copy link
Member

ocefpaf commented Mar 7, 2023

The user lists all the packages they want; and the solver will respect xarray's run constraints. Sounds like a feature!

Yeah. We, conda-forge, should probably add those automatically for python projects in our recipes via grayskull. The problem is that most Python packages use this so loosely that we will probably create packages that are too "rigid" to install rather than more stable solves.

TL;DR the xarray metadata is solid and that makes sense here. Doing that for all packages, not so much.

@hmaarrfk
Copy link

hmaarrfk commented Apr 5, 2023

is pandas 2 safe?

@ocefpaf
Copy link
Member

ocefpaf commented Apr 5, 2023

is pandas 2 safe?

For the xarray version in this PR? No. But if we are to merge this we would rebase and the latest version of xarray already pins pandas accordingly.

@dcherian dcherian mentioned this pull request Apr 14, 2023
3 tasks
@dcherian dcherian marked this pull request as ready for review June 14, 2023 22:55
@jhamman jhamman mentioned this pull request Aug 20, 2023
3 tasks
@jhamman
Copy link
Member

jhamman commented Aug 20, 2023

closed by #93

@jhamman jhamman closed this Aug 20, 2023
@dcherian dcherian deleted the patch-1 branch August 20, 2023 23:43
@dcherian dcherian mentioned this pull request Sep 26, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Many tests fail: AttributeError: 'cftime._cftime.DatetimeJulian' object has no attribute 'daysinmonth'
4 participants