-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure the correct version is reported by the build process #104
Ensure the correct version is reported by the build process #104
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12342558185. Examine the logs at this URL for more detail. |
So I think ffmpeg changed some of its interface in 7.1 which caused me grief. It is also possible that pyav changed things in version 14. So many things…. |
Looking at the logs it seems like av’s usage needs to be patched Hopefully just in the tests so we can avoid repo data patches |
@conda-forge-admin please rerender |
Need to back port |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basically LGTM, aside from sharpening the pip version test perhaps
Hi! This is the friendly conda-forge automerge bot! Commits were made to this PR after the |
1 similar comment
Hi! This is the friendly conda-forge automerge bot! Commits were made to this PR after the |
@conda-forge-admin please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12340046148. Examine the logs at this URL for more detail. |
Do you know how to address the arch failure? |
@conda-forge-admin please rerender |
1 similar comment
@conda-forge-admin please rerender |
Thanks! libwebp was found by the package inspection, we should add it as a host dependency. |
@conda-forge-admin please rerender |
43aa1b6
to
04e2f83
Compare
thank you so much for your help. going to add automerge. |
You're welcome! :) I'd like to try removing your work-arounds though; they shouldn't be necessary anymore AFAIU. |
04e2f83
to
26a5514
Compare
26a5514
to
87ee227
Compare
Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #103.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.
Fixes #103