Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the correct version is reported by the build process #104

Merged

Conversation

conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #103.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

Fixes #103

@conda-forge-admin
Copy link
Contributor Author

conda-forge-admin commented Dec 14, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12342558185. Examine the logs at this URL for more detail.

@conda-forge-admin conda-forge-admin marked this pull request as ready for review December 14, 2024 23:54
@hmaarrfk hmaarrfk changed the title MNT: rerender Ensure the correct version is reported by the build process Dec 14, 2024
@hmaarrfk
Copy link
Contributor

So I think ffmpeg changed some of its interface in 7.1 which caused me grief. It is also possible that pyav changed things in version 14.

So many things….

@hmaarrfk
Copy link
Contributor

Looking at the logs it seems like av’s usage needs to be patched

Hopefully just in the tests so we can avoid repo data patches

@hmaarrfk
Copy link
Contributor

@conda-forge-admin please rerender

@hmaarrfk
Copy link
Contributor

Need to back port

pytorch/vision#8776

recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
@hmaarrfk hmaarrfk added the automerge Merge the PR when CI passes label Dec 15, 2024
recipe/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-admin
Copy link
Contributor Author

conda-forge-admin commented Dec 15, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically LGTM, aside from sharpening the pip version test perhaps

@conda-forge-curator conda-forge-curator bot removed the automerge Merge the PR when CI passes label Dec 15, 2024
@conda-forge-admin
Copy link
Contributor Author

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

1 similar comment
@conda-forge-admin
Copy link
Contributor Author

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@conda-forge-curator conda-forge-curator bot removed the automerge Merge the PR when CI passes label Dec 15, 2024
@hmaarrfk
Copy link
Contributor

@conda-forge-admin please rerender

@conda-forge-admin
Copy link
Contributor Author

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12340046148. Examine the logs at this URL for more detail.

@hmaarrfk
Copy link
Contributor

Do you know how to address the arch failure?

@hmaarrfk
Copy link
Contributor

@conda-forge-admin please rerender

1 similar comment
@hmaarrfk
Copy link
Contributor

@conda-forge-admin please rerender

recipe/meta.yaml Outdated Show resolved Hide resolved
@hmaarrfk
Copy link
Contributor

Thanks!

libwebp was found by the package inspection, we should add it as a host dependency.

@hmaarrfk
Copy link
Contributor

@conda-forge-admin please rerender

@hmaarrfk hmaarrfk force-pushed the conda_forge_admin_103 branch 2 times, most recently from 43aa1b6 to 04e2f83 Compare December 15, 2024 21:00
@hmaarrfk
Copy link
Contributor

thank you so much for your help. going to add automerge.

@hmaarrfk hmaarrfk added the automerge Merge the PR when CI passes label Dec 15, 2024
@h-vetinari
Copy link
Member

thank you so much for your help. going to add automerge.

You're welcome! :)

I'd like to try removing your work-arounds though; they shouldn't be necessary anymore AFAIU.

recipe/meta.yaml Outdated Show resolved Hide resolved
@h-vetinari h-vetinari removed the automerge Merge the PR when CI passes label Dec 15, 2024
@hmaarrfk hmaarrfk force-pushed the conda_forge_admin_103 branch from 04e2f83 to 26a5514 Compare December 15, 2024 21:15
@hmaarrfk hmaarrfk force-pushed the conda_forge_admin_103 branch from 26a5514 to 87ee227 Compare December 15, 2024 21:52
@hmaarrfk hmaarrfk added the automerge Merge the PR when CI passes label Dec 15, 2024
@conda-forge-admin conda-forge-admin merged commit 2338e34 into conda-forge:main Dec 15, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin please rerender
3 participants