-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libfabric recipe #27988
Add libfabric recipe #27988
Conversation
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11500410963. |
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( For recipes/libfabric/meta.yaml:
Documentation on acceptable licenses can be found here. |
@minrk Can you want to have a look, please? |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/libfabric/meta.yaml:
For recipes/libfabric/meta.yaml:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( For recipes/libfabric/meta.yaml:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Co-authored-by: Min RK <benjaminrk@gmail.com>
Co-authored-by: Min RK <benjaminrk@gmail.com>
Co-authored-by: Min RK <benjaminrk@gmail.com>
Co-authored-by: Min RK <benjaminrk@gmail.com>
Co-authored-by: Min RK <benjaminrk@gmail.com>
Welcome @minrk Co-authored-by: Min RK <benjaminrk@gmail.com>
@minrk I guess that this is as far as we can go for Can you do the merge yourself or does it have to be someone different? |
I'll not merge it. We can ping the staged-recipes reviewers when it's ready. But I think we don't quite have numa/libnl working right on linux because of the output:
which means they are not linked by libfabric. What features do you expect to result from these, and how could you add them to a test? For example, I see from the
The only reference I can find to libnl is in
so it would appear that usnic depends on verbs, which is not installed. This is in Alternatively, we could start with a totally default build (as we are currently getting in the bundled mpich and openmpi, I believe, so I don't think this is a regression) without libnl and numa on all platforms, and add those on the feedstock. I think that's what this feedstock is actually building now, despite the attempts to link numa/libnl. Either that, or try adding |
@minrk is that any better now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making progress, thank you! I have some questions inline about the latest added dependencies and ignore_run_exports
.
I think the main remaining thing before this is ready for review is a run_test.sh
that verifies the expected components are available. Or if you think the commands are simple enough, they can be in test.commands, but I expect it will be clearer in a run_test.sh.
minor recipe cleanup
@conda-forge/help-c-cpp, ready for review! |
@xhochy Thanks Uwe |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).