Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW: Add recipe for libnvimgcodec #27546

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

carterbox
Copy link
Member

@carterbox carterbox commented Sep 11, 2024

closes #28218

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

conda-forge-webservices bot commented Sep 11, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/nvimgcodec/meta.yaml, recipes/libnvimgcodec/meta.yaml) and found some lint.

Here's what I've got...

For recipes/nvimgcodec/meta.yaml:

  • The extra section contained an unexpected subsection name. feedstock_name is not a valid subsection name.

For recipes/libnvimgcodec/meta.yaml:

  • The extra section contained an unexpected subsection name. feedstock_name is not a valid subsection name.

For recipes/libnvimgcodec/meta.yaml:

  • Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [138].

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 1, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/nvimgcodec/meta.yaml, recipes/libnvimgcodec/meta.yaml) and found it was in an excellent condition.

- python-clang
host:
- cuda-version {{ cuda_compiler_version }}
- dlpack
Copy link
Member Author

@carterbox carterbox Nov 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try adding cuda-cudart-dev to help Windows find cuda.h

mkdir build
cd build

nvimg_build_args=(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any build options missing?

- libboost-headers
- libjpeg-turbo
{% if cuda_major == 12 %}
- libnvjpeg-dev
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should dependencies linked with dlopen be made optional or converted to standard dynamic links?

- Library/lib/cmake/nvimgcodec # [win]
- etc/** # [linux]
- Library/etc/** # [win]
- extensions/*.so # [linux]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is PREFIX/extensions the "correct" place to install these modules?

{% if cuda_major == 12 %}
- libnvjpeg-dev
{% endif %}
- libopencv
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strongly consider making opencv optional for users because it is heavy

@carterbox carterbox self-assigned this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Package request: nvimgcodec
2 participants