-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW: Add recipe for libnvimgcodec #27546
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/nvimgcodec/meta.yaml:
For recipes/libnvimgcodec/meta.yaml:
For recipes/libnvimgcodec/meta.yaml:
|
ec1eb15
to
fefb9c1
Compare
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
- python-clang | ||
host: | ||
- cuda-version {{ cuda_compiler_version }} | ||
- dlpack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try adding cuda-cudart-dev
to help Windows find cuda.h
mkdir build | ||
cd build | ||
|
||
nvimg_build_args=( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any build options missing?
- libboost-headers | ||
- libjpeg-turbo | ||
{% if cuda_major == 12 %} | ||
- libnvjpeg-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should dependencies linked with dlopen be made optional or converted to standard dynamic links?
- Library/lib/cmake/nvimgcodec # [win] | ||
- etc/** # [linux] | ||
- Library/etc/** # [win] | ||
- extensions/*.so # [linux] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is PREFIX/extensions the "correct" place to install these modules?
{% if cuda_major == 12 %} | ||
- libnvjpeg-dev | ||
{% endif %} | ||
- libopencv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strongly consider making opencv optional for users because it is heavy
closes #28218
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).