-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New conda-forge recipe for climlab #2708
Conversation
…ld dependencies. Set version to 0.5.1 from pypi
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/climlab:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipes/climlab/meta.yaml
Outdated
|
||
requirements: | ||
build: | ||
- python 2.7* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add another skip statement above like: # [win or not py2k]
instead of pinning the python version here.
recipes/climlab/meta.yaml
Outdated
- numpy x.x | ||
- toolchain | ||
- gcc | ||
- libgfortran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gcc
brings libgfortran
so there is no need to specify it here. (It is a run time dependency only.)
…uild requirements
Thanks @ocefpaf for these suggestions! The build is still failing on circleci and I'm not sure why. |
Usually Linux (CircleCI) is easier than Do you know how to run the docker image locally? (http://conda-forge.github.io/docs/testing.html#run-docker-tests-locally-for-feedstock) That can help you debug it. If Linux is not mandatory for you now just add another skip condition so we can merge this and you can work on fixing it in the feedstock. |
The linux build is failing with linker errors:
I am struggling with this. Anyone have suggestions? I encounter the same type of error when running conda-build with this recipe on my local linux system. On the other hand, the package will build without complaint by manually running |
I don't have time to look at it right now but you probably need to either adapt the Fortran code or some compiler flag that will make it work with For now I recommend you to skip the build on |
Need to solve a gfortran linking problem that is causing the linux build to fail.
Thanks @ocefpaf. I am skipping |
When you create the issue in the feedstock ping me and I will take a look. Maybe it is something simple that we are missing now. |
Copying directly from conda-forge recipe from scipy, which also needs to build fortran code using numpy.distutils. We are trying agin to get the linux build working, with yum_requirements.txt copied from scipy.
Build is now working on OSX and linux! I mimicked the scipy recipe as closely as possible. The trick for building on linux seems to be the inclusion of |
Anything else needed before this cam be merged? |
I should mention that building climlab on Windows is definitely on my wish-list (this is educational software designed for wide deployment on students' laptops). But from what I can gather, building Fortran extensions for Windows is not yet possible on conda-forge, and probably won't be until there's a working conda-forge recipe for |
ping @ocefpaf |
This is a recipe for the climlab packge, which is a climate modeling toolkit written in Python with some underlying numerics in Fortran.
climlab builds against numpy using
numpy.distutils
to compile Fortran extension modules.I have tested this recipe on OSX and linux and posted the resulting binaries to https://anaconda.org/brian-rose/climlab.
I would love to get
climlab
integrated into conda-forge going forward for easier deployment.Thanks.