Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add waybackpy_3.0.2 #17643

Merged
merged 3 commits into from
Jan 26, 2022
Merged

add waybackpy_3.0.2 #17643

merged 3 commits into from
Jan 26, 2022

Conversation

rafaelrdealmeida
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/waybackpy_3.0.1) and found it was in an excellent condition.

@rafaelrdealmeida rafaelrdealmeida mentioned this pull request Jan 25, 2022
9 tasks
@rafaelrdealmeida
Copy link
Contributor Author

new PR with requested adjustments on old PR see: #17634

@rafaelrdealmeida
Copy link
Contributor Author

@conda-forge/core, please help

@wolfv
Copy link
Member

wolfv commented Jan 25, 2022

Looks like this might be related to this blob: https://github.com/akamhy/waybackpy/blob/4408c5e2ca8b875fff8db13d8172c5f025b1127e/waybackpy/cli.py#L172-L179

@rafaelrdealmeida
Copy link
Contributor Author

rafaelrdealmeida commented Jan 25, 2022

Looks like this might be related to this blob: https://github.com/akamhy/waybackpy/blob/4408c5e2ca8b875fff8db13d8172c5f025b1127e/waybackpy/cli.py#L172-L179

Hi @wolfv , thanks for the reply!

Any suggestion on how to resolve?

Would I be able to do a test before doing a PR in waybackpy?

cheers

@wolfv
Copy link
Member

wolfv commented Jan 25, 2022

remove the ASCII art with a patch or skip the test.

@akamhy
Copy link
Member

akamhy commented Jan 25, 2022

remove the ASCII art with a patch or skip the test.

I have replaced the art (akamhy/waybackpy@5ea1d3b), also the problematic art was not really ASCII art. The problem was probably caused because it was not ASCII but Unicode.

And @rafaelrdealmeida I have uploaded a new release to PyPI with the figlet changed.

The newer version is : 3.0.2
and sha256 is : 4a8b66c5de6c1a62076de798a8b7000cad9782ec7de45ac5dc71cc00a4674c35

You may either update the values on this PR/create a patch or just skip the tests.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/waybackpy_3.0.2) and found it was in an excellent condition.

@rafaelrdealmeida rafaelrdealmeida changed the title add waybackpy_3.0.1 add waybackpy_3.0.2 Jan 25, 2022
@rafaelrdealmeida
Copy link
Contributor Author

thanks @wolfv, @bollwyvl, @akamhy!

@wolfv wolfv merged commit 752905f into conda-forge:main Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants