Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add esmvalcore package (closes #14400) #14401

Merged
merged 16 commits into from
Apr 1, 2021

Conversation

zklaus
Copy link
Contributor

@zklaus zklaus commented Mar 26, 2021

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/esmvalcore) and found some lint.

Here's what I've got...

For recipes/esmvalcore:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/esmvalcore) and found some lint.

Here's what I've got...

For recipes/esmvalcore:

  • requirements: host: python >= 3.6 should not contain a space between relational operator and the version, i.e. python >=3.6
  • requirements: run: python >= 3.6 should not contain a space between relational operator and the version, i.e. python >=3.6

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/esmvalcore) and found it was in an excellent condition.

@zklaus
Copy link
Contributor Author

zklaus commented Mar 26, 2021

@bouweandela, @valeriupredoi I created this conda-forge version of esmvalcore. As you can see, it builds for Linux, but not for win nor osx. I think windows is unattainable at the moment. Do we provide/expect an osx build?

@valeriupredoi
Copy link

@zklaus that's very cool! No need to build the package in OSX, it installs well from conda using the Linux noarch one, see our GA tests - the Win one is all smoke and mirrors so really no support for that 👍

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/esmvalcore) and found some lint.

Here's what I've got...

For recipes/esmvalcore:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/esmvalcore) and found it was in an excellent condition.

@valeriupredoi
Copy link

hey @zklaus awesome job on the OSX recipe, mate! The tests are dying on OSX because of this issue and fix ESMValGroup/ESMValCore#1003 - if we fix it that way in ESMValTool too they won't fail no more

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/esmvalcore) and found some lint.

Here's what I've got...

For recipes/esmvalcore:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/esmvalcore) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/esmvalcore) and found some lint.

Here's what I've got...

For recipes/esmvalcore:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/esmvalcore) and found it was in an excellent condition.

@dopplershift dopplershift merged commit d7adadf into conda-forge:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants