Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builds #154

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Fix builds #154

merged 3 commits into from
Jul 29, 2024

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Jul 29, 2024

Closes #153
Fixes #152
Fixes #151

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

Ah, I keep forgetting that spacy insists on tracing, which cython doesn't support for py3.12 yet...

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Jul 29, 2024
@h-vetinari h-vetinari changed the title Fix builds, unskip python 3.12 Fix builds Jul 29, 2024
@h-vetinari
Copy link
Member Author

@rxm7706, I just saw that you introduced numpy >=1.15 in 1a275ae. I understand the desire to follow the upstream version constraints to the letter, but for numpy this ends up breaking a lot of things - please don't do it. For more details see here

@rxm7706
Copy link
Contributor

rxm7706 commented Jul 29, 2024

@rxm7706, I just saw that you introduced numpy >=1.15 in 1a275ae. I understand the desire to follow the upstream version constraints to the letter, but for numpy this ends up breaking a lot of things - please don't do it. For more details see here

Understood - Thank you @h-vetinari , for the fix and the explanation.

@github-actions github-actions bot merged commit 8607a71 into conda-forge:main Jul 29, 2024
26 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@h-vetinari h-vetinari deleted the fix branch July 29, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
2 participants