Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebuild with unpatched & GA build-deps #287

Merged
merged 8 commits into from
Oct 21, 2024
Merged

Rebuild with unpatched & GA build-deps #287

merged 8 commits into from
Oct 21, 2024

Conversation

h-vetinari
Copy link
Member

We also don't need llvm_rc anymore! 🥳

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

This was referenced Oct 10, 2024
Closed
Closed
@h-vetinari h-vetinari mentioned this pull request Oct 10, 2024
Merged
@h-vetinari
Copy link
Member Author

@eli-schwartz happy to report that (after the fixes we discussed) meson 1.6.0rc1 works for scipy in conda-forge! :)

@h-vetinari
Remove python_rc channels
5e0f3e5 
Revert "manually fix up windows channel sources due to smithy bug"

This reverts commit 5eb8df4.

Revert "fix channel situation on windows"

This reverts commit af35e4e.
@h-vetinari
remove llvm_rc label
eca8942
@h-vetinari
remove pypy remnants
136d362
@h-vetinari
switch to proper fortran compiler setup also on windows
c012459
@h-vetinari
add flang migration
d3145bd
@h-vetinari
bump build number
7e3dd52
@h-vetinari h-vetinari changed the title Test with meson 1.6.0rc1 Rebuild with unpatched & GA build-deps Oct 20, 2024
@h-vetinari h-vetinari marked this pull request as ready for review October 20, 2024 23:21
@h-vetinari
Copy link
Member Author

A year after #255, we're now able to build with "stock" packages. 🤩

Things have come quite a way since then. :)

@eli-schwartz
Copy link

🎉

@h-vetinari h-vetinari merged commit 3cf51e1 into conda-forge:main Oct 21, 2024
27 checks passed
@h-vetinari h-vetinari deleted the meson branch October 21, 2024 03:16
@rgommers
Copy link
Contributor

Awesome!

The build log is looking pretty good. One thing to follow up on may be these warnings, since they pollute the log pretty heavily:

flang-new: warning: argument unused during compilation: '-Wall' [-Wunused-command-line-argument]

@h-vetinari
Copy link
Member Author

Yeah, flang is very noisy with unknown flags. In openblas I had to use -w to make it bearable. Hopefully this gets better over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner

@ocefpaf ocefpaf Awaiting requested review from ocefpaf ocefpaf is a code owner

@rgommers rgommers Awaiting requested review from rgommers rgommers is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@h-vetinari @conda-forge-admin @eli-schwartz @rgommers