Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.18.2 (NumPy 1.11) #52

Merged
merged 2 commits into from
Jun 23, 2017
Merged

Release 0.18.2 (NumPy 1.11) #52

merged 2 commits into from
Jun 23, 2017

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Jun 21, 2017 •
edited
Loading

Releases 0.18.2 built with NumPy 1.11.

Other 0.18.2 Numpy builds:

cc @amueller

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

This was referenced Jun 21, 2017
Merged
Merged
@jakirkham
Update skip test patch for 0.18.2
beb9b7d 
We did not backport the fixes for these tests into the 0.18.2 release.
So we need to update this patch so that it will work correctly with
0.18.2.
@jakirkham
Copy link
Member Author

Feedback on this?

ogrisel
ogrisel approved these changes Jun 21, 2017
View reviewed changes
Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakirkham
Copy link
Member Author

Thanks for taking a look @ogrisel. Is there feedback from others or are we good to merge? @lesteve?

Also would be good if others double check the other 2 PRs here.

@jakirkham jakirkham merged commit 0fe434a into conda-forge:master_np1.11 Jun 23, 2017
@jakirkham jakirkham deleted the release_0.18.2_np1.11 branch June 23, 2017 15:48
@jakirkham
Copy link
Member Author

jakirkham commented Jun 23, 2017 •
edited
Loading

Went ahead and merged these to get the new release out. Given these have been pretty quiet for the past few days, I'm guessing we are happy with the result or at least not worried about it. Not to mention they are pretty minor in nature (i.e. version bump and slight tweak to the existing test patch). If that's not the case, please feel free to let me know. Am more than happy to discuss changes that may be needed.

@ogrisel
Copy link
Contributor

ogrisel commented Jun 23, 2017

Thanks, indeed that should be quite safe.

@jakirkham jakirkham mentioned this pull request Jul 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakirkham @conda-forge-linter @ogrisel