Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prrng v0.5.0 #7

Merged
merged 16 commits into from
May 20, 2021
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
    Checklist before merging this PR:
  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/859712640, please use this URL for debugging

Here is a list of all the pending dependencies (and their versions) for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
python 3.9.5 Anaconda-Server Badge
xtensor 21.8 Anaconda-Server Badge

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis of the source code shows a discrepancy between the library's imports and the package's stated requirements in the meta.yaml.

Packages found by inspection but not in the meta.yaml:

  • setuptools_scm

@conda-forge-linter
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@tdegeus
Copy link
Member

tdegeus commented May 20, 2021

@conda-forge-admin, please rerender

conda-forge-linter and others added 2 commits May 20, 2021 09:40
@tdegeus
Copy link
Member

tdegeus commented May 20, 2021

@conda-forge-admin, please rerender

conda-forge-linter and others added 2 commits May 20, 2021 09:54
@tdegeus
Copy link
Member

tdegeus commented May 20, 2021

@conda-forge-admin, please rerender

@mbargull
Copy link
Member

The cmake call from setup.py does not have the install prefix path and other arguments. You could try

-        cmake_args = [
+        cmake_args = shlex.split(os.environ.get('CMAKE_ARGS', ''))
+        cmake_args += [

(CMAKE_ARGS is populated by our compiler activation scripts with some defaults since some time.)
at https://github.com/tdegeus/prrng/blob/v0.5.0/setup.py#L48 and see if that helps (I'd use a patch here first to see if it works before upstreaming it; also, no idea if/what different things have to be done on Windows).
I don't know if that'll do it, but it's worth a shot.

@tdegeus
Copy link
Member

tdegeus commented May 20, 2021

@mbargull Thanks. I will give it a try, though it would have to be rather specific to NumPy then:

  • The feedstock worked before when I was not yet relying on NumPy
  • Everything works locally in a conda environment

@tdegeus
Copy link
Member

tdegeus commented May 20, 2021

@mbargull I tried to debug by calling CMake directly (before calling the setup.py). One of the things I tried was your suggestion. Unfortunately it did not help. All I can say for certain is:

  • I verified python -c "import numpy" before the CMake call and it passes. So NumPy is there. It's just CMake that doesn't know how to find it.
  • CMake does use the FindPython from the build enviroment.
  • I do specify the python executable from the Python environment to CMake

@conda-forge/help-python-c

@mbargull
Copy link
Member

Do you still have the build logs from 2a88bb0 (or can re-run it)?
That commit is the one with CMAKE_ARGS, i.e., the one that also has CMAKE_FIND_ROOT_PATH. I'm curious if there are slightly different outputs there or not.
(But overall, it is really strange that it finds the correct interpreter from the host environment but then uses the system's one for the NumPy check; no idea why that happens.)

@tdegeus
Copy link
Member

tdegeus commented May 20, 2021

@mbargull The latest build is with CMAKE_ARGS (at least in Linux and OSx). I don't have the impression it changed anything...

@mbargull
Copy link
Member

@mbargull The latest build is with CMAKE_ARGS (at least in Linux and OSx). I don't have the impression it changed anything...

Oh, right, sorry, I just had a brief look at the commits and mistook the .bat for .sh in between.

@@ -1,4 +1,6 @@
python -c "import numpy"
echo `which python`
echo "$PYTHON"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, the recipe uses outputs, so possibly you run in some kind of variant of conda/conda-build#3993 , i.e., I wouldn't be surprised if $PYTHON is not set correctly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But even then,

(But overall, it is really strange that it finds the correct interpreter from the host environment but then uses the system's one for the NumPy check; no idea why that happens.)

would still be strange.

@tdegeus
Copy link
Member

tdegeus commented May 20, 2021

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@tdegeus tdegeus merged commit 552912d into conda-forge:master May 20, 2021
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 0.5.0_hda3201 branch May 20, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants