Rebuild for libboost 1.82 #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nda-forge-pinning 2023.09.29.05.06.46
h-vetinari
requested review from
ocefpaf,
pkgw,
xhochy and
xylar
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
h-vetinari
commented
Sep 29, 2023
recipe/meta.yaml
Outdated
| - cairo | ||
| - curl | ||
| - fontconfig | ||
| - freetype | ||
| - gettext | ||
| - glib | ||
| - libboost-devel |
There was a problem hiding this comment.
use libboost-devel because of the run-dep (now handled through the run-export)...
| - cairo | ||
| - curl | ||
| - fontconfig | ||
| - freetype | ||
| - gettext | ||
| - glib | ||
| - libboost-headers |
There was a problem hiding this comment.
And libboost-headers where there's not run-dep (and hence no run-requirement). Due to the layered build here, we should still verify that the link-check agrees.
There was a problem hiding this comment.
All builds have:
WARNING (poppler): dso library package conda-forge::libboost-1.82.0-hf0c313a_3 in requirements/run but it is not used (i.e. it is overdepending or perhaps statically linked? If that is what you want then add it to `build/ignore_run_exports`)
so indeed, we don't need -devel here.
|
@conda-forge/poppler, this should be ready, PTAL! :) |
xhochy
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sounds like the piggyback migrator hit a corner-case, do it manually.