Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for latest fontconfig changes #124

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

xylar
Copy link
Contributor

@xylar xylar commented Mar 9, 2022

Add @xylar as a maintainer.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@xylar xylar requested review from ocefpaf, pkgw and xhochy as code owners March 9, 2022 12:06
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xylar
Copy link
Contributor Author

xylar commented Mar 9, 2022

We're seeing issues in:
conda-forge/gdal-feedstock#611
That seem related to:
conda-forge/fontconfig-feedstock#53

It seems like (conda-forge/fontconfig-feedstock#53 (comment)) the easiest solution is to rebuild packages that depend on fontconfig to bring in these changes.

@xylar
Copy link
Contributor Author

xylar commented Mar 9, 2022

@conda-forge-admin, please rerender

@xylar
Copy link
Contributor Author

xylar commented Mar 9, 2022

@ocefpaf, @xhochy and @pkgw, I wanted to check with you whether you think a rebuild is all that's needed here to bring in conda-forge/fontconfig-feedstock#53. CI hasn't finished yet but I figured it wouldn't hurt to get your sense of it before it does.

I added myself as a maintainer but I tend not to be particularly helpful for non-python feedstocks so I would be happy to take myself off the list if you prefer, no hard feelings for sure.

@pkgw
Copy link
Contributor

pkgw commented Mar 9, 2022

Yes, I believe that a rebuild is all that's needed, but I see that the mac builds here are failing because cairo needs to be rebuilt first. So (cf. the other thread) if we'd rather rebuild dependers than patch the macOS package, it looks like a migration would definitely be the way to go.

I should also say, happy to have you as a maintainer! As far as I'm concerned there's no downside if you don't mind the extra notifications.

@xylar
Copy link
Contributor Author

xylar commented Mar 9, 2022

I'm definitely in favor of a migrator but maybe we want to get gdal working again faster than a migrator would allow for.

@xylar
Copy link
Contributor Author

xylar commented Mar 9, 2022

Waiting for conda-forge/cairo-feedstock#62.

@pkgw
Copy link
Contributor

pkgw commented Mar 9, 2022

Cairo is now merged. Will have to wait a couple of hours for the builds to finish and propagate, but hopefully this build will work after that happens.

@xylar xylar closed this Mar 9, 2022
@xylar xylar reopened this Mar 9, 2022
@xylar
Copy link
Contributor Author

xylar commented Mar 9, 2022

The new cairo package should now be available. Let's see what happens.

@zklaus
Copy link

zklaus commented Mar 9, 2022

@conda-forge-admin, please restart ci

@pkgw pkgw merged commit 455ba37 into conda-forge:master Mar 10, 2022
@xylar xylar deleted the rebuild_for_latest_fontconfig branch March 10, 2022 08:23
@xylar
Copy link
Contributor Author

xylar commented Mar 10, 2022

Thanks again, @pkgw and @zklaus

@zklaus
Copy link

zklaus commented Mar 10, 2022

Cheers @xylar. Thanks for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants