Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pandas v2.0.0 #159

Merged
merged 4 commits into from
Apr 3, 2023
Merged

pandas v2.0.0 #159

merged 4 commits into from
Apr 3, 2023

Conversation

datapythonista
Copy link
Member

Checklist

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • requirements: run: tzdata>=2022a must contain a space between the name and the pin, i.e. tzdata >=2022a

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@datapythonista
Copy link
Member Author

Added tzdata, @MarcoGorelli do you mind having a look?

@MarcoGorelli
Copy link
Member

from pandas-dev/pandas#51247 (comment) , it looks like you've done exactly that - @lithomas1 do you know what the issue might be?

the logs show

2023-04-03T14:01:12.6088211Z pandas 2.0.0 requires tzdata, which is not installed.
2023-04-03T14:01:12.8512388Z Tests failed for pandas-2.0.0-py38hdc8b05c_0.conda - moving package to /home/conda/feedstock_root/build_artifacts/broken
2023-04-03T14:01:12.8513965Z WARNING:conda_build.build:Tests failed for pandas-2.0.0-py38hdc8b05c_0.conda - moving package to /home/conda/feedstock_root/build_artifacts/broken
2023-04-03T14:01:12.8809618Z TESTS FAILED: pandas-2.0.0-py38hdc8b05c_0.conda
2023-04-03T14:01:19.3131987Z ##[error]Bash exited with code '1'.

@MarcoGorelli
Copy link
Member

should tzdata be removed from run, and - {{ PYTHON }} -m pip install tzdata>=2022.1 be added to script?

recipe/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: Filipe <ocefpaf@gmail.com>
@MarcoGorelli
Copy link
Member

MarcoGorelli commented Apr 3, 2023

I presume you mean 3.9? Pandas isn't compatible with just ZoneInfo yet, but once it drops 3.8 support, then it can drop pytz and just use ZoneInfo

For context, here's the issue where it was suggested to add tzdata as a dependency pandas-dev/pandas#49048

@alippai
Copy link

alippai commented Apr 3, 2023

I presume you mean 3.9? Pandas isn't compatible with just ZoneInfo yet, but once it drops 3.8 support, then it can drop pytz and just use ZoneInfo

For context, here's the issue where it was suggested to add tzdata as a dependency pandas-dev/pandas#49048

Thank you, found the discussion about it later, hence the deleted comment.

run:
- python
- {{ pin_compatible('numpy') }}
- python-dateutil >=2.8.1
- pytz >=2020.1
- python-tzdata >=2022a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, tzdata is included in modern Python but pip is designed to find it only if installed by the python alternative like this. We could probably drop the pip check test too. But "overi-nstalling" tzdata is not a big deal and probably better than dropping the pip-check.

@datapythonista
Copy link
Member Author

Seems like we have a failure in a build:

Traceback (most recent call last):
  File "C:\Miniforge\Scripts\conda-mambabuild-script.py", line 9, in <module>
    sys.exit(main())
  File "C:\Miniforge\lib\site-packages\boa\cli\mambabuild.py", line 256, in main
    call_conda_build(action, config)
  File "C:\Miniforge\lib\site-packages\boa\cli\mambabuild.py", line 228, in call_conda_build
    result = api.build(
  File "C:\Miniforge\lib\site-packages\conda_build\api.py", line 180, in build
    return build_tree(
  File "C:\Miniforge\lib\site-packages\conda_build\build.py", line 3089, in build_tree
    test(pkg, config=metadata.config.copy(), stats=stats)
  File "C:\Miniforge\lib\site-packages\conda_build\build.py", line 2879, in test
    environ.create_env(metadata.config.test_prefix, actions, config=metadata.config,
  File "C:\Miniforge\lib\site-packages\conda_build\environ.py", line 1052, in create_env
    display_actions(actions, index)
  File "C:\Miniforge\lib\site-packages\conda\exports.py", line 204, in display_actions
    actions['LINK'] = [index[d] for d in actions['LINK']]
  File "C:\Miniforge\lib\site-packages\conda\exports.py", line 204, in <listcomp>
    actions['LINK'] = [index[d] for d in actions['LINK']]
KeyError: Dist(channel='conda-forge', dist_name='pytz-2023.3-pyhd8ed1ab_0', name='pytz', fmt='.conda', version='2023.3', build_string='pyhd8ed1ab_0', build_number=0, base_url=None, platform=None)

I guess something went wrong with conda. @ocefpaf have you seen this before? Do you think we should just rerun that build?

@ocefpaf
Copy link
Member

ocefpaf commented Apr 3, 2023

I guess something went wrong with conda. @ocefpaf have you seen this before? Do you think we should just rerun that build?

It may requite a restart. Let's wait for the rest of the CIs to finish before we restart it.

@ocefpaf
Copy link
Member

ocefpaf commented Apr 3, 2023

BTW, we should wait for conda-forge/status#143 to be resolved before merging this one.

@ocefpaf
Copy link
Member

ocefpaf commented Apr 3, 2023

The ppc ones had some real failures. Looks like precision stuff and maybe be same to skip, not sure.

@datapythonista
Copy link
Member Author

Thanks for the help and for the info.

We found the error with ppc on the release candidates, we're happy to release without ppc. Hopefully we have a fix for pandas 2.0.1. Let's see if we're more lucky with the second attempt of the other error.

It starts to be late in Dubai where I am, but for anyone else in a better time zone, feel free to merge this if only ppc is failing. Otherwise I'll take care of it tomorrow morning my time.

@datapythonista
Copy link
Member Author

Feel free to merge if conda-forge/status#143 is also addressed I mean.

@datapythonista datapythonista mentioned this pull request Apr 3, 2023
1 task
@ocefpaf ocefpaf merged commit 76269c3 into conda-forge:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants