Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pkgconfig metadata on windows #106

Merged
merged 6 commits into from
Sep 8, 2022
Merged

Conversation

h-vetinari
Copy link
Member

This would be useful to be able to run test for pkgconfig-metadata in dependent repos, e.g. grpc-cpp, c.f. conda-forge/grpc-cpp-feedstock#239

Content is taken from https://github.com/microsoft/vcpkg/blob/master/ports/openssl/install-pc-files.cmake and cross-referenced with our own pkgconfig files on unix (from where I took the formatting).

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari force-pushed the pkg branch 2 times, most recently from bcd9252 to 806bbe9 Compare September 7, 2022 12:21
@h-vetinari
Copy link
Member Author

@hmaarrfk @isuruf
Any thoughts on this? I'd like to add tests for the pkg-config metadata on the grpc-cpp feedstock (not least if we're trying to remove private libs like zlib or abseil from the link interface), and had to disable this on windows because it fails to find openssl.pc.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Sep 7, 2022

I'm a fan of the idea. I would just prefer not having m2 for now.

Can we simply use echo?

Less elegant than a template file maybe, but won't pull in a whole new stack.

@h-vetinari
Copy link
Member Author

Less elegant than a template file maybe, but won't pull in a whole new stack.

Yes, agreed, but also... it's only during the build phase (so nothing in the final artefact)? Any specific concerns you have in mind?

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Sep 7, 2022

Any specific concerns you have in mind?

Yes. I mostly fear that the build system will find some strange dependency and end up depending on m2

@h-vetinari
Copy link
Member Author

@hmaarrfk PTAL :)

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Sep 8, 2022

This looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants