-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pkgconfig metadata on windows #106
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
bcd9252
to
806bbe9
Compare
I'm a fan of the idea. I would just prefer not having m2 for now. Can we simply use echo? Less elegant than a template file maybe, but won't pull in a whole new stack. |
Yes, agreed, but also... it's only during the build phase (so nothing in the final artefact)? Any specific concerns you have in mind? |
Yes. I mostly fear that the build system will find some strange dependency and end up depending on m2 |
@hmaarrfk PTAL :) |
This looks good to me. |
This would be useful to be able to run test for pkgconfig-metadata in dependent repos, e.g. grpc-cpp, c.f. conda-forge/grpc-cpp-feedstock#239
Content is taken from https://github.com/microsoft/vcpkg/blob/master/ports/openssl/install-pc-files.cmake and cross-referenced with our own pkgconfig files on unix (from where I took the formatting).