Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update recipe (build and testing) #41

Merged
merged 4 commits into from
Aug 18, 2019
Merged

Conversation

dalcinl
Copy link
Contributor

@dalcinl dalcinl commented Jun 29, 2019

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

recipe/meta.yaml Show resolved Hide resolved
* Do not remove --as-needed from LDFLAGS
* Add test for mpiexec with shell script
* Add test for mpifort compiler wrapper
@ax3l
Copy link
Member

ax3l commented Jul 10, 2019

@conda-forge-admin, please rerender

(so we get the fixed conda-build 3.18.7 with conda/conda-build#3596 )

@ax3l
Copy link
Member

ax3l commented Jul 10, 2019

sorry, still too old in the bot

@minrk
Copy link
Member

minrk commented Jul 12, 2019

Pretty sure this will succeed after the aarch64 build finishes. Then happy to have it merged.

@dalcinl
Copy link
Contributor Author

dalcinl commented Jul 12, 2019

@minrk Please look at the aarch64 build log, particularly the testing of the openmpi package.

The following NEW packages will be INSTALLED:

    mpi:     1.0-openmpi      conda-forge
    openmpi: 4.0.1-hc99cbb1_2 local      

This smells like dependencies on the C++/Fortran runtime libraries are still broken. Or I am missing something?

Should we just ignore this issue and merge?

I'm tempted to backport the mpivars program from MPICH and install it in $PREFIX/bin, this way we have an actual binary executable that uses MPI, so we can test the core openmpi package. And as a side benefit, the mpivars program is actually useful.

@minrk
Copy link
Member

minrk commented Jul 12, 2019

You're right, conda/conda-build#3583 is indeed not fixed in conda-build 3.18.7

@minrk
Copy link
Member

minrk commented Jul 12, 2019

We still need to wait for conda-build to fix run_exports before we can make any aarch64 packages. This should put a pause on any/all aarch64 builds across conda-forge, I think.

@ax3l
Copy link
Member

ax3l commented Jul 12, 2019

@conda-forge-admin, please rerender

(note we are still not using the latest conda-build)

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

1 similar comment
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@mariusvniekerk
Copy link
Member

@minrk Is this right now?

@minrk minrk closed this Jul 16, 2019
@minrk minrk reopened this Jul 16, 2019
@minrk
Copy link
Member

minrk commented Jul 16, 2019

@mariusvniekerk triggering rebuild now to check. The last build was not correct.

@minrk
Copy link
Member

minrk commented Jul 16, 2019

@mariusvniekerk No, the build is still incorrect on aarch64, missing strong run_exports from the compilers.

@minrk
Copy link
Member

minrk commented Jul 25, 2019

@conda-forge-admin, please rerender

I think the latest CB release may fix this.

@mariusvniekerk
Copy link
Member

Fingers crossed

@dalcinl
Copy link
Contributor Author

dalcinl commented Aug 17, 2019

@conda-forge-admin, please rerender

@dalcinl
Copy link
Contributor Author

dalcinl commented Aug 17, 2019

@beckermr I checked carefully the pkg dependencies of the macOS builds and both look good to me. Could you please double check them and confirm?

PS: I still need to wait for the Linux aarch64 build to check they are OK (we had dependency issues in there).

@beckermr
Copy link
Member

LGTM! The aarch64 build will take a while.

@beckermr
Copy link
Member

@dalcinl Please close #45 when you merge this.

@beckermr
Copy link
Member

huzzah!

@dalcinl dalcinl merged commit e5e312d into conda-forge:master Aug 18, 2019
@dalcinl dalcinl deleted the update branch August 18, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants