Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openmp v19.1.0 #144

Merged
merged 36 commits into from
Oct 1, 2024
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
compiler-rt 19.1.0 Anaconda-Server Badge
llvmdev 19.1.0 Anaconda-Server Badge

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.

conda-forge-curator bot and others added 30 commits March 15, 2024 20:14
This reverts commit 61a838f.
[dev] Actually enable fortran bits on windows
automerged PR by conda-forge/automerge-action
automerged PR by conda-forge/automerge-action
@h-vetinari
Copy link
Member

Windows builds here will need flang 19 to be built (exceptionally, as we're adding the fortran bits now, c.f. #134; for LLVM 20+ we shouldn't need the newest flang to build openmp)

@h-vetinari
Copy link
Member

@conda-forge/openmp, aside from waiting for the flang builds on windows, this is ready, PTAL! :)

@h-vetinari
Copy link
Member

@conda-forge/openmp, this is ready now, PTAL! :)

@h-vetinari
Copy link
Member

Kind ping @conda-forge/openmp, PTAL.

@h-vetinari
Copy link
Member

Ping @conda-forge/openmp. Given that #134 (for the meat of the change here) received no comments in >2 months, I'm going to merge this in roughly 24h, unless there are other comments.

@isuruf
Copy link
Member

isuruf commented Sep 24, 2024

Commented at #134 (comment)

@h-vetinari
Copy link
Member

Commented at #134 (comment)

Thanks. I'm answering here because based on the comments I don't think we want to backport this feature to 18.x

@isuruf: Can we move the .mod file to a different output? The cycles are also there in linux if we switch _openmp_mutex.

I can try - currently assuming this can be done in a separate output here. How would you like to name this output? openmp-fortran?

@isuruf
Copy link
Member

isuruf commented Sep 24, 2024

llvm-openmp-fortran? Also I'm not sure how this omp_lib.mod is going to be used with gfortran in Linux given that gfortran has it's own omp_lib.mod for libgomp.

@h-vetinari
Copy link
Member

h-vetinari commented Sep 25, 2024

llvm-openmp-fortran? Also I'm not sure how this omp_lib.mod is going to be used with gfortran in Linux given that gfortran has it's own omp_lib.mod for libgomp.

Should we move GCC's omp_lib.mod into libgomp or create a similar libgomp-fortran output that's under the same mutex as the current openmp implementations?

Edit: had some leftover text in my phone's editor, sorry

@h-vetinari
Copy link
Member

Should we move GCC's omp_lib.mod into libgomp or create a similar libgomp-fortran output that's under the same mutex as the current openmp implementations?

Ping @isuruf

@isuruf
Copy link
Member

isuruf commented Sep 30, 2024

Should we move GCC's omp_lib.mod into libgomp or create a similar libgomp-fortran output that's under the same mutex as the current openmp implementations?

Can you give an example of how omp_lib.mod here is going to be used with gfortran?

@h-vetinari
Copy link
Member

Should we move GCC's omp_lib.mod into libgomp or create a similar libgomp-fortran output that's under the same mutex as the current openmp implementations?

Can you give an example of how omp_lib.mod here is going to be used with gfortran?

Building openblas with openmp support (conda-forge/openblas-feedstock#115) failed without the omp_lib.mod files. Presumably the ones for gfortran already get picked up from libgomp

@isuruf
Copy link
Member

isuruf commented Sep 30, 2024

Can you be more specific? The PR is green

@h-vetinari
Copy link
Member

Can you be more specific? The PR is green

That PR doesn't build the llvm variant for openmp on linux. But it's green on windows because of the changes in this PR (as present in the dev/rc builds). I'm happy to descope the Fortran bits on Unix, but we need them on windows.

@isuruf
Copy link
Member

isuruf commented Sep 30, 2024

Okay, then. Please remove the Unix parts.

@h-vetinari
Copy link
Member

Okay, then. Please remove the Unix parts.

OK, sounds good. Do we still need to have the separation into separate outputs then?

@isuruf
Copy link
Member

isuruf commented Sep 30, 2024

Do we still need to have the separation into separate outputs then?

Yep, to avoid having to do that in the future if/when unix builds get added.

@h-vetinari
Copy link
Member

do that in the future if/when unix builds get added.

Could we defer the separate output until such time when unix builds get added, or at least after the 19.1.0 release (I'd be willing to open a PR)?

@isuruf
Copy link
Member

isuruf commented Sep 30, 2024

Can we drop the .mod files all ogether, get the 19 release out and deal with it later?

@h-vetinari
Copy link
Member

Can we drop the .mod files all ogether, get the 19 release out and deal with it later?

OK. The flang migration on windows still needs them, but that's yet another separate milestone before the mod files ever become relevant on unix.

@h-vetinari
Copy link
Member

As this is now a vanilla version update (and we discussed "get the 19 release out" without the .mod files), I'm merging this. I'll bring back the changes in an updated #134

@h-vetinari h-vetinari merged commit 18e9556 into conda-forge:main Oct 1, 2024
8 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 19.1.0_h955772 branch October 1, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants