-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenCV 4.10.0 - Numpy 2.0 #417
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
0e4319b
to
55aa35e
Compare
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.06.03.07.43.01
Do we want to drop qt5 builds |
Fine by me per se. What's the status on the overall qt6 migration? How many feedstocks (if any) are still qt5-only? I'd kinda like to drop qt5 in general... |
Spyder is in general PyQt (not sure if they handle 6) and require webengine. Which we don't have for Qt6. However. All platforms have a "headless" option. So it should be co-installable, just without the GUI parts on opencv. |
Let's move this discussion to a wider forum... |
The situation here is exceptional in many ways - the outputs are named differently ( |
qt is in fact, an exceptional package! |
So the unique thing here is that users can still install opencv + spyder. They just won't be able to get:
They owuld get
I think that is ok..... |
Worth noting that this also contains NumPy 2 support |
ah, then maybe the right thing is to pull in the numpy 2.0 migration and "do one last qt5 build". I "promise it will be the last one". |
@ilya-lavrenov could you pull in the numpy 2.0 migration from: it should build in a way that is compatible with numpy 1.X and 2.X giving this the last hurra! |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally. This message was generated by GitHub actions workflow run https://github.com/conda-forge/opencv-feedstock/actions/runs/9364092311. |
c858606
to
fc26e7f
Compare
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.06.03.19.07.16
Looks like numpy 2.0 is not supported by OpenCV. |
According to opencv/opencv#25455 opencv 4.10 should support numpy 2. |
There is probably something off in our windows installation script. |
Back when I started to get involved in CF, one of my major contributions was a refactor to this installation script. there is probably alot left over from the python 2.7/3 days that can be removed. If you do end up attempting a cleanup Ilya, please skip most of the jobs by adding something like:
and troubleshoot with that. |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Congratulations all! 🥳 Thanks for all your hard work on getting this one done! 👏 |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)