Rebuild for numpy 2.0 #68

regro-cf-autotick-bot · 2024-05-25T19:20:37Z

This PR has been triggered in an effort to update numpy2.

Notes and instructions for merging this PR:

Please merge the PR only after the tests have passed.
Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

Here are some more details about this specific migrator:

TL;DR: The way we build against numpy has changed as of numpy 2.0. This bot
PR has updated the recipe to account for the changes (see below for details).
The numpy 2.0 package itself is currently only available from a special release
channel (conda-forge/label/numpy_rc) and will not be available on the main
conda-forge channel until the release of numpy 2.0 GA.

The biggest change is that we no longer need to use the oldest available numpy
version at build time in order to support old numpy version at runtime - numpy
will by default use a compatible ABI for the oldest still-supported numpy versions.

Additionally, we no longer need to use {{ pin_compatible("numpy") }} as a
run requirement - this has been handled for more than two years now by a
run-export on the numpy package itself. The migrator will therefore remove
any occurrences of this.

However, by default, building against numpy 2.0 will assume that the package
is compatible with numpy 2.0, which is not necessarily the case. You should
check that the upstream package explicitly supports numpy 2.0, otherwise you
need to add a - numpy <2 run requirement until that happens (check numpy
issue 26191 for an overview of the most important packages).

Note that the numpy release candidate promises to be ABI-compatible with the
final 2.0 release. This means that building against 2.0.0rc1 produces packages
that can be published to our main channels.

If you already want to use the numpy 2.0 release candidate yourself, you can do
conda config --add channels conda-forge/label/numpy_rc
or add this channel to your .condarc file directly.

To-Dos:

Match run-requirements for numpy (i.e. check upstream pyproject.toml or however the project specifies numpy compatibility)

If upstream is not yet compatible with numpy 2.0, add numpy <2 upper bound under run:.

If upstream is already compatible with numpy 2.0, nothing else should be necessary in most cases.

If upstream requires a minimum numpy version newer than 1.19, you can add numpy >=x.y under run:.

Remove any remaining occurrences of {{ pin_compatible("numpy") }} that the bot may have missed.

PS. If the build does not compile anymore, this is almost certainly a sign that
the upstream project is not yet ready for numpy 2.0; do not close this PR until
a version compatible with numpy 2.0 has been released upstream and on this
feedstock (in the meantime, you can keep the bot from reopening this PR in
case of git conflicts by marking it as a draft).

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

_{This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/9237273570 - please use this URL for debugging.}

TL;DR: The way we build against numpy has changed as of numpy 2.0. This bot PR has updated the recipe to account for the changes (see below for details). The numpy 2.0 package itself is currently only available from a special release channel (`conda-forge/label/numpy_rc`) and will not be available on the main `conda-forge` channel until the release of numpy 2.0 GA. The biggest change is that we no longer need to use the oldest available numpy version at build time in order to support old numpy version at runtime - numpy will by default use a compatible ABI for the oldest still-supported numpy versions. Additionally, we no longer need to use `{{ pin_compatible("numpy") }}` as a run requirement - this has been handled for more than two years now by a run-export on the numpy package itself. The migrator will therefore remove any occurrences of this. However, by default, building against numpy 2.0 will assume that the package is compatible with numpy 2.0, which is not necessarily the case. You should check that the upstream package explicitly supports numpy 2.0, otherwise you need to add a `- numpy <2` run requirement until that happens (check numpy issue 26191 for an overview of the most important packages). Note that the numpy release candidate promises to be ABI-compatible with the final 2.0 release. This means that building against 2.0.0rc1 produces packages that can be published to our main channels. If you already want to use the numpy 2.0 release candidate yourself, you can do ``` conda config --add channels conda-forge/label/numpy_rc ``` or add this channel to your `.condarc` file directly. ### To-Dos: * [ ] Match run-requirements for numpy (i.e. check upstream `pyproject.toml` or however the project specifies numpy compatibility) * If upstream is not yet compatible with numpy 2.0, add `numpy <2` upper bound under `run:`. * If upstream is already compatible with numpy 2.0, nothing else should be necessary in most cases. * If upstream requires a minimum numpy version newer than 1.19, you can add `numpy >=x.y` under `run:`. * [ ] Remove any remaining occurrences of `{{ pin_compatible("numpy") }}` that the bot may have missed. PS. If the build does not compile anymore, this is almost certainly a sign that the upstream project is not yet ready for numpy 2.0; do not close this PR until a version compatible with numpy 2.0 has been released upstream and on this feedstock (in the meantime, you can keep the bot from reopening this PR in case of git conflicts by marking it as a draft).

…nda-forge-pinning 2024.05.25.13.27.35

conda-forge-webservices · 2024-05-25T19:20:44Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

megies · 2024-05-27T08:24:37Z

Not sure what's going on here. The bot says..

If upstream is not yet compatible with numpy 2.0, add numpy <2 upper bound under run:

..but I already did that in an earlier PR and under run: section we have the following but for testing the built package still numpy 2 gets installed and tests are run on numpy 2.0.0rc2 which can't work:

  run:
    - numpy >=1.20,<2

In any case, we can worry about this PR after next release which will likely be compatible with numpy 2.

megies · 2024-05-27T09:09:10Z

Still numpy 2.0.0rc2 gets installed in the env used to run tests on the built package even when numpy <2 pin is in place in

run section
tests section

EDIT: pinning <2 still matches 2.0 prereleases, need to pin 2.0dev0

see https://conda.discourse.group/t/conda-forge-testing-package-with-numpy-2-0-0rc2-although-we-pin-numpy-2/628

…e specs" This reverts commit 84bc346.

megies · 2024-05-27T09:41:30Z

@conda-forge-admin, please rerender

github-actions · 2024-05-27T09:42:52Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/obspy-feedstock/actions/runs/9252720617.

megies · 2024-05-28T07:10:34Z

Not sure what the problem with these couple builds is.. seems like it's failing to resolve all dependencies for the build environment.. I checked and at least for linux aarch64 py3.11 I can confirm the numpy 2.0.0rc2 is up on Anaconda, so not sure what's up. Probably just wait a week or two and retry CI.

megies · 2024-06-03T09:35:34Z

Re-run the failed builds, still failing

megies · 2024-06-18T08:21:30Z

Not sure how to proceed here, these couple of builds still keep failing

ThomasLecocq · 2024-07-02T11:58:04Z

looks like dependencies issues:

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=943308&view=logs&j=937e5276-98a9-5c64-e305-04e0d24ab531&t=ca8af55c-56a0-524a-fc78-b3a1ab219e0b&l=1008

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=943308&view=logs&j=64bf9f8b-01e1-5f0a-59e1-97ab66046df4&t=4c840100-54bb-53b6-e05e-86564b8d8dcf&l=1190

is it a problem of "resolving" the RC builds?

would it make sense to already build for the successful OS/versions ? is that at all possible?

ThomasLecocq · 2024-07-02T12:10:08Z

@megies this? conda-forge/conda-forge.github.io#1997 (comment)

and this: conda-forge/conda-forge.github.io#1997 (comment) with ref to the RC channel?

ThomasLecocq · 2024-07-02T16:26:47Z

am very outside my confort zone, but that error

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=968224&view=logs&j=1e869e56-b0a2-5745-eb6f-ceaab3c34dd0&t=1eb80998-6df2-53a6-6da3-1c6173e52460&l=1173

doesn't seem to make sense. The builder is using rc builds of python ? uh ?

ThomasLecocq · 2024-07-02T16:33:40Z

since the numpy RC channel has been removed, maybe it'd be easier to

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one.

ThomasLecocq · 2024-07-02T16:36:52Z

@conda-forge-admin, please rerun bot

regro-cf-autotick-bot · 2024-07-02T17:06:00Z

Due to the bot-rerun label I'm closing this PR. I will make another one as appropriate. This message was generated by https://github.com/regro/cf-scripts/actions/runs/9765025159 - please use this URL for debugging.

regro-cf-autotick-bot added 2 commits May 25, 2024 19:11

MNT: Re-rendered with conda-build 24.5.0, conda-smithy 3.36.0, and co…

b09e8e9

…nda-forge-pinning 2024.05.25.13.27.35

regro-cf-autotick-bot requested review from QuLogic, ThomasLecocq, barsch, krischer and megies as code owners May 25, 2024 19:20

megies marked this pull request as draft May 27, 2024 08:24

pin numpy <2 for test environment in addition to "run" package specs

84bc346

megies added 2 commits May 27, 2024 11:31

Revert "pin numpy <2 for test environment in addition to "run" packag…

37d835f

…e specs" This reverts commit 84bc346.

avoid 2.0.0rc2 being considered usable when pinning "<2"

550a239

megies mentioned this pull request May 29, 2024

Just a test #69

Closed

5 tasks

trigger build

418f47b

ThomasLecocq added the bot-rerun Instruct the bot to retry the PR label Jul 2, 2024

regro-cf-autotick-bot closed this Jul 2, 2024

regro-cf-autotick-bot deleted the rebuild-numpy2-0-1_h44c34e branch July 2, 2024 17:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebuild for numpy 2.0 #68

Rebuild for numpy 2.0 #68

regro-cf-autotick-bot commented May 25, 2024

conda-forge-webservices bot commented May 25, 2024

megies commented May 27, 2024 •

edited

Loading

megies commented May 27, 2024 •

edited

Loading

megies commented May 27, 2024

github-actions bot commented May 27, 2024

megies commented May 28, 2024

megies commented Jun 3, 2024

megies commented Jun 18, 2024

ThomasLecocq commented Jul 2, 2024 •

edited

Loading

ThomasLecocq commented Jul 2, 2024

ThomasLecocq commented Jul 2, 2024

ThomasLecocq commented Jul 2, 2024

ThomasLecocq commented Jul 2, 2024

regro-cf-autotick-bot commented Jul 2, 2024

Rebuild for numpy 2.0 #68

Rebuild for numpy 2.0 #68

Conversation

regro-cf-autotick-bot commented May 25, 2024

To-Dos:

conda-forge-webservices bot commented May 25, 2024

megies commented May 27, 2024 • edited Loading

megies commented May 27, 2024 • edited Loading

megies commented May 27, 2024

github-actions bot commented May 27, 2024

megies commented May 28, 2024

megies commented Jun 3, 2024

megies commented Jun 18, 2024

ThomasLecocq commented Jul 2, 2024 • edited Loading

ThomasLecocq commented Jul 2, 2024

ThomasLecocq commented Jul 2, 2024

ThomasLecocq commented Jul 2, 2024

ThomasLecocq commented Jul 2, 2024

regro-cf-autotick-bot commented Jul 2, 2024

megies commented May 27, 2024 •

edited

Loading

megies commented May 27, 2024 •

edited

Loading

ThomasLecocq commented Jul 2, 2024 •

edited

Loading