Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numexpr v2.8.4 #45

Merged
merged 3 commits into from
Apr 3, 2023
Merged

numexpr v2.8.4 #45

merged 3 commits into from
Apr 3, 2023

Conversation

apmorton
Copy link
Contributor

@apmorton apmorton commented Mar 31, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@apmorton apmorton mentioned this pull request Apr 1, 2023
5 tasks
@@ -7,9 +7,9 @@ channel_targets:
cxx_compiler:
- vs2019
mkl:
- '2022'
- '2022.1.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to pins those via a local conda_build_config.yaml file or they'll be removed in the next re-render.

Try a file with:

mkl:
  - 2022.1.0
mkl_devel:
  - 2022.1.0

in the recipe folder and then re-render.

@apmorton
Copy link
Contributor Author

apmorton commented Apr 3, 2023 via email

@ocefpaf
Copy link
Member

ocefpaf commented Apr 3, 2023

Is there a way to pin those for just the windows builds?

mkl:  # [win]
  - 2022.1.0  # [win]
mkl_devel:  # [win]
  - 2022.1.0  # [win]

This should work (untested)!

@apmorton
Copy link
Contributor Author

apmorton commented Apr 3, 2023

Appears to have worked perfectly, thanks!

@ocefpaf ocefpaf added the automerge Merge the PR when CI passes label Apr 3, 2023
@github-actions github-actions bot merged commit 635de0e into conda-forge:main Apr 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@apmorton apmorton deleted the am/update branch April 3, 2023 14:02
@apmorton
Copy link
Contributor Author

apmorton commented Apr 3, 2023

@ocefpaf any ideas? the build seems stuck in a loop trying to upload:


ERROR getting output validation information from the webservice: JSONDecodeError('Expecting value: line 1 column 1 (char 0)')
copy results:
{}
Failed to upload due to copy from staging to production channel failed. Trying again in 10 seconds

@ocefpaf
Copy link
Member

ocefpaf commented Apr 3, 2023

Not sure. Let's wait for the re-tries.

@apmorton
Copy link
Contributor Author

apmorton commented Apr 3, 2023

They have all failed 😞

@apmorton
Copy link
Contributor Author

apmorton commented Apr 3, 2023

Looking at a few other feedstock pipelines it appears this is not an issue with this feedstock, other main branch builds have failed to upload with the same error.

See: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=683522&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=e5c8ab1d-8ff9-5cae-b332-e15ae582ed2d

@apmorton
Copy link
Contributor Author

apmorton commented Apr 3, 2023

See: conda-forge/status#143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants