Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest version 11.5.1 #25

Merged
merged 16 commits into from
Oct 19, 2023
Merged

Update to latest version 11.5.1 #25

merged 16 commits into from
Oct 19, 2023

Conversation

saraedum
Copy link
Member

@saraedum saraedum commented Oct 12, 2023 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@saraedum saraedum requested a review from isuruf as a code owner October 12, 2023 21:48
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@saraedum
Copy link
Member Author

@conda-forge-admin, please rerender

@saraedum saraedum mentioned this pull request Oct 12, 2023
Open
conda-forge-webservices[bot] and others added 2 commits October 12, 2023 21:50
MNT: Re-rendered with conda-build 3.27.0, conda-smithy 3.27.1, and co…
eb4c68e 
…nda-forge-pinning 2023.10.12.13.22.36
@saraedum
Add myself as a maintainer
c87938c 
since I am a maintainer of most of the SageMath dependencies
@saraedum
Copy link
Member Author

@conda-forge-admin, please rerender

@saraedum
Copy link
Member Author

@isuruf, any ideas here?

./MakeDesc
make[1]: ./MakeDesc: Bad CPU type in executable

Seems like NTL is building a binary that checks the system for features. When cross-compiling this won't work. I guess I could manually run this on an M1 mac and then copy the result over as a patch.

@isuruf
Copy link
Member

isuruf commented Oct 13, 2023

Cross compiling does not work here. I build it locally on an M1 in the past. We can merge this PR without osx-arm64. If you can build the package locally and upload it to your channel and post the log here, I can copy it over to conda-forge.

@saraedum
Copy link
Member Author

Cross compiling does not work here. I build it locally on an M1 in the past. We can merge this PR without osx-arm64. If you can build the package locally and upload it to your channel and post the log here, I can copy it over to conda-forge.

So, there's more trouble after MakeDesc even if we patch that one out somehow?

@saraedum saraedum closed this Oct 13, 2023
@saraedum saraedum reopened this Oct 13, 2023
@saraedum saraedum closed this Oct 13, 2023
@saraedum saraedum reopened this Oct 13, 2023
@saraedum
Copy link
Member Author

🎉 @isuruf

@saraedum saraedum mentioned this pull request Oct 16, 2023
Merged
6 tasks
@saraedum
Copy link
Member Author

@isuruf: do you think we could get this one merged?

@isuruf isuruf merged commit 2d4e1cd into conda-forge:main Oct 19, 2023
5 checks passed
@isuruf
Copy link
Member

isuruf commented Oct 19, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isuruf isuruf Awaiting requested review from isuruf isuruf is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saraedum @isuruf