Win64: Do not skip run_exports directives for mumps-seq #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
requested review from
basnijholt,
dalcinl,
davidbrochart,
jbweston,
minrk and
SylvainCorlay
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
5 tasks
…da-forge-pinning 2020.11.08.20.44.44
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. |
traversaro
changed the title
|
Friendly ping @conda-forge/mumps . I am not sure if the original description was clear enough, so I added some additional details. |
|
LGTM! Thanks 👍 |
|
Thanks a lot @basnijholt ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows support was added in #56, but the run_exports directly were still decorated by
#[no win]. Without this fix, any package that compiles against the shared library provided bymumps-seqneed to declare the run dependency on it, but just for Windows, that may result in problems difficult to debug as the test failures in the examples added in conda-forge/ipopt-feedstock#47 .Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)