-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Try to build with flang 18 on Windows #111
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you but ran into some issues. Please check the output logs of the latest rerendering GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or try re-rendering locally. This message was generated by GitHub actions workflow run https://github.com/conda-forge/mumps-feedstock/actions/runs/7783826409. |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.02.05.10.57.46
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.02.05.10.57.46
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/mumps-feedstock/actions/runs/7783996051. |
Current failures:
interestingly, the library installed by https://anaconda.org/conda-forge/libfortran-main is called |
Indeed, the problem is that with flang 18.1.0rc1
while flang 17 returned:
|
I guess that the
probably we need to add them in https://github.com/conda-forge/flang-feedstock/blob/rc/recipe/install_libfortran_main.bat#L3 . @h-vetinari are you interested in PRs on the rc branch of flang-feedstock, or are you still working on that so you prefer to handle that yourself? Thanks a lot in advance! |
Thanks for the analysis, would gladly take a PR! I've noted some relevant changes during the 18 cycle in an issue on the flang feedstock, but I haven't analysed all consequences. This looks like it's one of them. |
Actually, I am not sure about what I written, it seems that |
Reading better the ninja error, I think that in |
Manually removing the problematic dependency from build.ninja, the compilation fails with this error:
|
sounds like flang isn't yet ready for certain syntax constructs (FIR is an intermediate representation during compilation). Did mumps build with flang 17 or is this the first time you're attempting it? If it's the former, then it's a regression. If it's the latter, it's probably on someone's to-do list already. But in any case, it's probably not a bad idea to raise an issue upstream. |
Hey @traversaro and @h-vetinari Now that the "lowering to FIR" issue in conda-forge And it seems like with the fix for flang this PR successfully compiles with only a minor addition. All I had to do was to add
in order to resolve some linking issues
|
Thanks @Krande , that is great! Feel free to edit the PR, I added you as a collaborator. Linking msvcrt sounds strange to me as I thought everything kind of migrated to ucrt, anyhow I am a bit short on time now, I will look in detail later. |
I wonder if there is some NODEFAULTLIB option being passed by someone? We could also test compiling with cl.exe instead of clang-cl.exe, for consistency with the rest of conda-forge |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.04.16.09.40.08
In order to align with cf common practice
Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/mumps-feedstock/actions/runs/8708334918. |
@traversaro If we want to build against metis and libscotch. I reckon we need to do something like scivision are doing in their FindMETIS.cmake? |
Yes, I guess so. |
That's great news! 🥳 CC also @isuruf |
We do set |
Note that flang only gained support for this option in LLVM 18, see conda-forge/flang-feedstock#35 |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.04.16.19.44.50
I rebased this PR in #119 for testing with the upcoming flang 19 |
(do not merge, just an experiment related to conda-forge/conda-forge-pinning-feedstock#1359)
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)