Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update recipe (build and testing) #40
Update recipe (build and testing) #40
Changes from 1 commit
495c068
374631d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, I think we can remove this. It's supposedly been fixed in mpich 3.2.1, but no harm keeping it for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. After this PR is merged, we have to update to mpich 3.3.1, I was planning to do it by then.
Or do you prefer to jump now to 3.3.1 and forget about getting fresh builds for 3.2.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the openmpi recipe, we still need the script to pass the
--allow-run-as-root
. Maybe it is a good idea to keep the mpiexex script in mpich as well, as a future last resort in case we are in need of similar tweaks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. No real difference between the script and the function that was here before. Still some arguments to consolidate. Without redirecting, an alias in
run_test.sh
ought to be enough.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, the use the function that was here before was broken, better to use a script in which we can control bash options. See this log https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=45392 and look for
./helloworld_c: error while loading shared libraries: libgfortran.so.4: cannot open shared object file: No such file or directory
. So eventually the PR was merged but the package was broken.This file was deleted.