Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add miniforge_console_shortcut on windows #88

Merged
merged 6 commits into from
Dec 30, 2020

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Dec 30, 2020

Fix #62.

  • Add miniforge_console_shortcut on windows to add start menu shortcut
  • Upload installer as github artefact when workflow doesn't run on tag.

@hmaarrfk
Copy link
Contributor

I'm confused about the necessity of menuinst is it still required to get the shortcuts to appear on windows? or has that been built into conda

@ericpre
Copy link
Member Author

ericpre commented Dec 30, 2020

menuinst is a dependency of conda. Also, there a few recipe using it on conda-forge, such as for example the ovito recipe and the menuinst dependency is not listed explicitly and I don't see why it would be necessary.
Also, I have added an option to upload the installer as github artefacts, so we can download the two windows installer and test them: it works as expected.

@@ -13,125 +13,145 @@ jobs:
ARCH: x86_64
MINIFORGE_NAME: "Miniforge3"
OS_NAME: "Windows"
UPLOAD_ARTEFACT: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove these and upload artifacts always

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was annoyed with getting one large artefact but setting the name of the artefact as you suggested above fix it!

@isuruf isuruf merged commit e365865 into conda-forge:master Dec 30, 2020
@isuruf
Copy link
Member

isuruf commented Dec 30, 2020

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Windows Installer does not provide a prompt, doesn't work in cmd
3 participants