Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format list of assets into a table #75

Merged
merged 3 commits into from
Dec 6, 2020

Conversation

SylvainCorlay
Copy link
Member

@SylvainCorlay SylvainCorlay commented Dec 6, 2020

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@isuruf
Copy link
Member

isuruf commented Dec 6, 2020

Should we merge the 4 tables into one with each type (Miniforge, Miniforge-pypy3, Mambaforge, Mambaforge-pypy3) getting a column each?

@SylvainCorlay
Copy link
Member Author

Should we merge the 4 tables into one with each type (Miniforge, Miniforge-pypy3, Mambaforge, Mambaforge-pypy3) getting a column each?

Why not, although this may be a bit dense for newcomers, and we would need to make a placeholder text for the download link to save some space.

@SylvainCorlay
Copy link
Member Author

I think the current version is clearer and a more dense single table.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
@isuruf
Copy link
Member

isuruf commented Dec 6, 2020

we would need to make a placeholder text for the download link to save some space.

we should do that anyway as some rows are wrapped into two lines at the moment

@SylvainCorlay SylvainCorlay merged commit 35d0cc2 into conda-forge:master Dec 6, 2020
@SylvainCorlay SylvainCorlay deleted the format-table branch December 6, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants