Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miniforge 4.9.2-0 #67

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Miniforge 4.9.2-0 #67

merged 3 commits into from
Dec 2, 2020

Conversation

romainx
Copy link
Contributor

@romainx romainx commented Dec 1, 2020

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Helllo,

The aim of this PR is to release a Miniforge 4.9.2 installer by bumping the conda dependency to 4.9.2.
It's also a way for me to understand the way Miniforge installers are built and released.

Many thanks.
Best.

The version should not be hardcoded. I'm checking how to fix it properly.
@romainx
Copy link
Contributor Author

romainx commented Dec 2, 2020

The version is hardcoded here.

if [[ "$(uname)" == MINGW* ]]; then
echo "start /wait \"\" build/Miniforge3-4.9.0-0-Windows-x86_64.exe /InstallationType=JustMe /RegisterPython=0 /S /D=$(cygpath -w $CONDA_PATH)" > install.bat
cmd.exe /c install.bat

I've made a quick fix to confirm and I'm looking further to fix it in a more robust way.

@romainx
Copy link
Contributor Author

romainx commented Dec 2, 2020

@isuruf Thank you for the fix. I did not take the time to read the script 🙃

@isuruf isuruf merged commit c617d50 into conda-forge:master Dec 2, 2020
@isuruf
Copy link
Member

isuruf commented Dec 2, 2020

Thanks for the PR

@romainx romainx deleted the feat_conda_4.9.2 branch December 2, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants