-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for ffmpeg44 #15
Rebuild for ffmpeg44 #15
Conversation
…nda-forge-pinning 2022.03.25.06.21.54
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
Documentation on acceptable licenses can be found here. |
@conda-forge/help-pypy The errors seems to be around:
is this something that is fixed in pypy 3.8? |
No. That is a private interface. As far as I can tell, the public access to it is via |
Thanks you seem to be correct |
There is also |
Truthfully, i'm not really too sure why: Got merged. This source code looks like it hasn't been updated since 2018 and would need some patching to not access the private API. (Human error likely) In my mind, since PyPy builds never succeded, it should be safe to disable them and merge this. |
ffmpeg 4.4 isn't a huge change from 4.3, we simply had some ABI breakage for OSX so we went over and patched things up. |
@conda-forge-admin please rerender |
…nda-forge-pinning 2022.03.30.18.03.29
@conda-forge/lintel I think this should be good to go. Do take a look if you have time. |
Given the pypy3.8 migration, lets merge this and let this block on the pypy3.8 migration. |
This PR has been triggered in an effort to update ffmpeg44.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2038674929, please use this URL for debugging.