getting curl's library not system one, fix #173 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
ocefpaf
requested changes
Oct 24, 2017
recipe/build.sh
Outdated
|
|
||
| # Build static. | ||
| cmake -D CMAKE_INSTALL_PREFIX=$PREFIX \ | ||
| -D CURL_INCLUDE_DIR=$PREFIX/include \ | ||
| -D CURL_LIBRARY=$PREFIX/lib/libcurl.$LD_SUFFIX \ |
There was a problem hiding this comment.
Please see 3a84292 for the use of SHLIB_EXT.
PS: the CIs indicate that it works and only conda-forge's curl is used 🎉
recipe/build.sh
Outdated
| @@ -1,7 +1,17 @@ | |||
| #!/bin/bash | |||
| if [ `uname` == "Linux" ]; then | |||
| LD_SUFFIX="so" | |||
There was a problem hiding this comment.
No need for the if-else clause. See my comment below.
recipe/build.sh
Outdated
| elif [ `uname` == "Darwin" ]; then | ||
| LD_SUFFIX="dylib" | ||
| else | ||
| LD_SUFFIX="DLL" |
There was a problem hiding this comment.
Assuming that everything else is Windows can be dangerous for other people than conda-forge that use this recipe to build on various platforms.
ocefpaf
approved these changes
Oct 24, 2017
|
Travis-CI passed on my instance. Merging this to unlock #26 Thanks @doutriaux1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.