-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zarr support #118
zarr support #118
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Looking at the logs it is enabled! I'll activate the tests later. |
…nda-forge-pinning 2021.04.07.18.46.00
@rsignell-usgs and @kmuehlbauer, as I suspected the zarr support is enabled by default and it is working. See https://nbviewer.jupyter.org/urls/gist.githubusercontent.com/ocefpaf/5482c2a43fcdb811ea23dcb466a76420/raw/2afb9a1f6fc6a26e0894ce23f3c278f78772dec9/netcdf-c-zarr.ipynb The zip files were not working though, we need to add libzip. Let's wait for conda-forge/conda-forge-pinning-feedstock#1418 to merge this one and get zip support. (In my gist above I have zip support b/c I used a local package built with it.) |
…nda-forge-pinning 2021.04.09.17.43.25
…nda-forge-pinning 2021.04.09.17.43.25
@isuruf I'm testing you suggestion but everything seems to be broken now. But I think it is unrelated :-/ |
Do we need the quotes round the test name? It is still trying to run it :-/ |
@dopplershift do you mind taking a look before we merge? If skipping that test is OK I'll trigger a pin update and a migration. |
@dopplershift and @kmuehlbauer note that this PR does not add the S3 features. We need to package https://github.com/aws/aws-sdk-cpp/tree/master/aws-cpp-sdk-s3 first to enable that. |
According to the docs the defaults are:
I added those anyway to see if we can enable the feature. I'll turn the test on in the next commits.