Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zarr support #118

Merged
merged 16 commits into from
Apr 18, 2021
Merged

zarr support #118

merged 16 commits into from
Apr 18, 2021

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Apr 7, 2021

According to the docs the defaults are:

The necessary CMake flags are as follows (with defaults)

-DENABLE_NCZARR=on – equivalent to the Automake –enable-nczarr option.
-DENABLE_NCZARR_S3=off – equivalent to the Automake –enable-nczarr-s3 option.
-DENABLE_NCZARR_S3_TESTS=off – equivalent to the Automake –enable-nczarr-s3-tests option.

I added those anyway to see if we can enable the feature. I'll turn the test on in the next commits.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ocefpaf ocefpaf marked this pull request as draft April 7, 2021 17:37
@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 7, 2021

Looking at the logs it is enabled! I'll activate the tests later.

@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 7, 2021

@rsignell-usgs and @kmuehlbauer, as I suspected the zarr support is enabled by default and it is working. See https://nbviewer.jupyter.org/urls/gist.githubusercontent.com/ocefpaf/5482c2a43fcdb811ea23dcb466a76420/raw/2afb9a1f6fc6a26e0894ce23f3c278f78772dec9/netcdf-c-zarr.ipynb

The zip files were not working though, we need to add libzip. Let's wait for conda-forge/conda-forge-pinning-feedstock#1418 to merge this one and get zip support. (In my gist above I have zip support b/c I used a local package built with it.)

@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 9, 2021

@isuruf I'm testing you suggestion but everything seems to be broken now. But I think it is unrelated :-/

@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 10, 2021

Do we need the quotes round the test name? It is still trying to run it :-/

recipe/build.sh Outdated Show resolved Hide resolved
@ocefpaf ocefpaf marked this pull request as ready for review April 10, 2021 23:29
@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 10, 2021

@dopplershift do you mind taking a look before we merge? If skipping that test is OK I'll trigger a pin update and a migration.

@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 11, 2021

@dopplershift and @kmuehlbauer note that this PR does not add the S3 features. We need to package https://github.com/aws/aws-sdk-cpp/tree/master/aws-cpp-sdk-s3 first to enable that.

@dopplershift
Copy link
Member

@ocefpaf I'd like to see what #119 shows first.

recipe/build.sh Outdated Show resolved Hide resolved
@ocefpaf ocefpaf merged commit 086355a into conda-forge:master Apr 18, 2021
@ocefpaf ocefpaf deleted the zarr branch April 18, 2021 11:54
@benbovy benbovy mentioned this pull request May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants