Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build 1.19.5 #29

Merged
merged 5 commits into from
Dec 27, 2024
Merged

build 1.19.5 #29

merged 5 commits into from
Dec 27, 2024

Conversation

akrherz
Copy link
Contributor

@akrherz akrherz commented Dec 26, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

The bot seems to be having trouble with the version update here: #28
fixes #27
@conda-forge-admin please rerender

@akrherz akrherz requested a review from frmdstryr as a code owner December 26, 2024 21:59
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 26, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-forge-tick (the bot). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12508899700. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12508954812. Examine the logs at this URL for more detail.

@akrherz
Copy link
Contributor Author

akrherz commented Dec 26, 2024

Windows build failing with

FAILED: tests/CMakeFiles/testframework.dir/catch_amalgamated.cpp.obj 
C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\1429~1.301\bin\HostX64\x64\cl.exe  /nologo /TP -DHAVE_VISIBILITY -DIS_BIG_ENDIAN=0 -DLIBHEIF_EXPORTS -I%SRC_DIR%\build -I%SRC_DIR%\libheif -I%SRC_DIR%\libheif\api -I%SRC_DIR%\include\libheif -I%SRC_DIR%\include /DWIN32 /D_WINDOWS /GR /EHsc /O2 /Ob2 /DNDEBUG -std:c++20 -MD -WX /showIncludes /Fotests\CMakeFiles\testframework.dir\catch_amalgamated.cpp.obj /Fdtests\CMakeFiles\testframework.dir\testframework.pdb /FS -c %SRC_DIR%\tests\catch_amalgamated.cpp
%SRC_DIR%\tests\catch_amalgamated.cpp(8072): error C2593: 'operator <<' is ambiguous
%SRC_DIR%\tests\catch_amalgamated.cpp(6598): note: could be 'std::ostream &Catch::operator <<(std::ostream &,Catch::StringRef)'
%SRC_DIR%\tests\catch_amalgamated.hpp(773): note: or       'std::ostream &Catch::operator <<(std::ostream &,Catch::StringRef)' [found using argument-dependent lookup]

@frmdstryr
Copy link
Contributor

frmdstryr commented Dec 26, 2024

@frmdstryr
Copy link
Contributor

frmdstryr commented Dec 26, 2024

Also I think the bot is complaining about {℅- at

{%- if license_family == 'gpl' %}
, can you try removing the dash or that whole if. Edit nevermind thats not a typo. Ping @hmaarrfk

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@akrherz
Copy link
Contributor Author

akrherz commented Dec 27, 2024

Thanks @frmdstryr for the review.

@frmdstryr frmdstryr merged commit 0df1fd5 into conda-forge:main Dec 27, 2024
15 checks passed
@frmdstryr
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin, please update version
3 participants