Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libfabric1 output for ABI tracking #16

Merged
merged 7 commits into from
Dec 16, 2024
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented Dec 7, 2024

  • adds libfabric1 output which has the library
  • libfabric-devel has unversioned .so symlink, headers, etc.. This is the package that should be in host, and has run_exports on both libfabric and libfabric1.
  • libfabric-bin has executables in bin/ (matches ubuntu)
  • libfabric is an empty metapackage, used only for mutual exclusivity and backward-compatibility so an env cannot have libfabric1 and future libfabric2 in the same env, which would very likely be undesirable

The ABI version is checked explicitly during build. This check will fail when the ABI version changes, which will prompt a manual change of the lower bound on libfabric1 in run_exports, at which point we'll need to re-check https://ofiwg.github.io/libfabric/main/man/fabric.7.html#abi-changes

update: now trying to follow suggestions in conda-forge/conda-forge.github.io#2401

and use abi version for run_exports

this check will fail when the ABI version changes,
which will prompt a manual change of run_exports

alternative: track abi as its own package
@minrk minrk requested a review from j34ni as a code owner December 7, 2024 14:10
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

as mentioned in the PR removing CURRENT_ABI
- libfabric1 has the actual DLL
- libfabric is empty for backward-compatibility, mutual exclusivity
- libfabric-devel has .so symlink, headers, etc.
- libfabric-bin has fi_info, etc.
@minrk minrk changed the title add explicit check for ABI version add libfabric1 output for ABI tracking Dec 11, 2024
so we don't need to track soversion_full, which will change on every release
only the flat output.files has the weird issue with build script
@minrk minrk merged commit a77c151 into conda-forge:main Dec 16, 2024
8 checks passed
@minrk minrk deleted the check_abi branch December 16, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants