Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python 3.6 and windows builds. #145

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Conversation

jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Oct 8, 2018

From @isuruf on the conda-forge gitter channel: https://gitter.im/conda-forge/conda-forge.github.io?at=5bbb8adb271506518dd861b7

python matrix builds are used if you have just - python as a requirement.
- python >= 3.5 means conda-build can use any python version >= 3.5 as a run requirement, but what we actually want is the python version that it built against as the run requirement”

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

From @isuruf on the conda-forge gitter channel: https://gitter.im/conda-forge/conda-forge.github.io?at=5bbb8adb271506518dd861b7

> python matrix builds are used if you have just - python as a requirement.
> - python >= 3.5 means conda-build can use any python version >= 3.5 as a run requirement, but what we actually want is the python version that it built against as the run requirement”
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jasongrout
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jasongrout
Copy link
Contributor Author

Fixes our changes at #144

@jasongrout
Copy link
Contributor Author

Checked the circleci py36 log, and indeed the python 3.6 package is getting built, not the python 3.7 package like before.

@blink1073
Copy link
Member

afk, but I think this same issue might be occuring with the latest ipython and jupyter_console feedstock releases.

@blink1073
Copy link
Member

LGTM, thanks!

@jasongrout
Copy link
Contributor Author

Thanks! Everything is passing now, so merging.

@jasongrout jasongrout merged commit c06156e into conda-forge:master Oct 8, 2018
@jasongrout
Copy link
Contributor Author

afk, but I think this same issue might be occuring with the latest ipython and jupyter_console feedstock releases.

ipython looks fine, and it turns out that in noarch packages (like jupyter_console), constraining the python version is the right way to do it (and in fact, skip lines in noarch packages fail in the linter).

@blink1073
Copy link
Member

Great, thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants