-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix python 3.6 and windows builds. #145
Conversation
From @isuruf on the conda-forge gitter channel: https://gitter.im/conda-forge/conda-forge.github.io?at=5bbb8adb271506518dd861b7 > python matrix builds are used if you have just - python as a requirement. > - python >= 3.5 means conda-build can use any python version >= 3.5 as a run requirement, but what we actually want is the python version that it built against as the run requirement”
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to re-render for you, but it looks like there was nothing to do. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Fixes our changes at #144 |
Checked the circleci py36 log, and indeed the python 3.6 package is getting built, not the python 3.7 package like before. |
afk, but I think this same issue might be occuring with the latest ipython and jupyter_console feedstock releases. |
LGTM, thanks! |
Thanks! Everything is passing now, so merging. |
ipython looks fine, and it turns out that in noarch packages (like jupyter_console), constraining the python version is the right way to do it (and in fact, |
Great, thanks for checking! |
From @isuruf on the conda-forge gitter channel: https://gitter.im/conda-forge/conda-forge.github.io?at=5bbb8adb271506518dd861b7
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)